Merge pull request Expensify#33440 from paultsimura/fix/33369-status-…

…loader fix: Status – remove redundant privatePersonalDetails dependencies
DanielOX · Dec 22, 2023 · b0e038f · b0e038f
2 parents 235c7b7 + 03685bb
commit b0e038f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 14 deletions.
diff --git a/src/pages/settings/Profile/CustomStatus/SetDatePage.js b/src/pages/settings/Profile/CustomStatus/SetDatePage.js
@@ -75,9 +75,6 @@ SetDatePage.displayName = 'SetDatePage';
 export default compose(
  withLocalize,
  withOnyx({
- privatePersonalDetails: {
- key: ONYXKEYS.PRIVATE_PERSONAL_DETAILS,
- },
  customStatus: {
  key: ONYXKEYS.CUSTOM_STATUS_DRAFT,
  },

diff --git a/src/pages/settings/Profile/CustomStatus/SetTimePage.js b/src/pages/settings/Profile/CustomStatus/SetTimePage.js
@@ -2,12 +2,10 @@ import lodashGet from 'lodash/get';
 import React from 'react';
 import {View} from 'react-native';
 import {withOnyx} from 'react-native-onyx';
-import FullscreenLoadingIndicator from '@components/FullscreenLoadingIndicator';
 import HeaderWithBackButton from '@components/HeaderWithBackButton';
 import ScreenWrapper from '@components/ScreenWrapper';
 import TimePicker from '@components/TimePicker/TimePicker';
 import withLocalize, {withLocalizePropTypes} from '@components/withLocalize';
-import usePrivatePersonalDetails from '@hooks/usePrivatePersonalDetails';
 import useThemeStyles from '@hooks/useThemeStyles';
 import * as User from '@libs/actions/User';
 import compose from '@libs/compose';
@@ -20,9 +18,7 @@ const propTypes = {
  ...withLocalizePropTypes,
 };
 
-function SetTimePage({translate, privatePersonalDetails, customStatus}) {
- usePrivatePersonalDetails();
-
+function SetTimePage({translate, customStatus}) {
  const styles = useThemeStyles();
  const clearAfter = lodashGet(customStatus, 'clearAfter', '');
 
@@ -33,9 +29,6 @@ function SetTimePage({translate, privatePersonalDetails, customStatus}) {
  Navigation.goBack(ROUTES.SETTINGS_STATUS_CLEAR_AFTER);
  };
 
- if (lodashGet(privatePersonalDetails, 'isLoading', true)) {
- return <FullscreenLoadingIndicator />;
- }
  return (
  <ScreenWrapper
  includeSafeAreaPaddingBottom
@@ -63,9 +56,6 @@ SetTimePage.displayName = 'SetTimePage';
 export default compose(
  withLocalize,
  withOnyx({
- privatePersonalDetails: {
- key: ONYXKEYS.PRIVATE_PERSONAL_DETAILS,
- },
  customStatus: {
  key: ONYXKEYS.CUSTOM_STATUS_DRAFT,
  },