Add support for a "give a" command to give player armour #136
Conversation
|
Tested in id1 and rogue
|
Can you comment a link to download your darkplaces with the GIVE A command that I can use in the meantime until this pull request is merged? |
I don't have any builds online, and can only build locally for Linux. |
I understand. Thank you. |
There was a problem hiding this comment.
Unfortunately Baker7's patch from #132 is a Quake-specific hack and it's the same problem here: it assumes all SVQC programs use the fields armortype and items in the same way that id1 Quake or Rogue did. items might be OK (its already set by the give command for weapons) but armortype has never been set by DP or FTE engines. Not all games have 3 types, those that do don't necessarily identify them with 0.8 0.6 and 0.3 (unlike the items bits, those aren't declared in progsdefs). Some games might even use this as a bitfield (eg indicating the player has a helmet but not boots). I think you can only set armortype safely for GAME_NORMAL and GAME_ROGUE, and probably others whose armour is id1 compatible. Xonotic and Nexuiz only have one type, I don't know about other games.
Currently this func uses LH's code style (see CONTRIBUTING.md) so it would be best if you could stick to that please.
Allows the command
give a #to give the player armour, just like the othergivecommands. Based on the example code provided by Baker7. Fixes #132 .