Muffle sounds when the player is under water #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemebond
changed the title
Enabled by default. Use 'snd_waterfx 0' to disable it. Adapted code from Ironwail so that it works in this engine. Cherry-picked from daftmugi/wrath-darkplaces
Signed-off-by: bones_was_here <[email protected]>
bones-was-here
force-pushed
the
feature/underwater-acoustics
branch
from
34b8977
to
aa40915
Compare
|
Nice effect. I made some adjustments: Rebased on current master. Moved 1 change into the original commit: qboolean -> qbool. This allows that commit to appear in the master history without it being a pain when using Squashed your fixes into a single commit, and omitted a few of the newlines you added there (the ones between the UNDERWATER EFFECT header and the code for that feature). Generally in DP extra newlines only go between sections, not within a section. Added a commit simplifying the code and clarifying that cvar Going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
daftmugi ported Ironwail's audio acoustic feature, muffling the intensity of sounds when the player is underwater, to the wrath-darkplaces repo. I've cherry-picked the commit (daftmugi/wrath-darkplaces@d732247).