Added Webassembly support and fixed GLES2 (somewhat) #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(For some reason, make exits with an error after building emscripten-release. Don't know how to fix it, please don't ask)
…tch your viewport.
…rom sys_wasm.c as it causes a compile error)
Change DP_LINK_JPEG back to dlopen Remove duplicate parameters
Create index.html as an example of how to use the Emscripten build. Make game resize on SDL resize events. Create autoexec.cfg to set some game settings. Update gitignore.
Update readme with instructions on how to server the wasm/index.html Revert the change that broke rendering in regular SDL builds Clean up makefiles Revert shader change which seems to do nothing Update path in index.html
Change WASM HTML page title
Fixes frame abort (it did an immediate unclean shutdown on all platforms). Fixes vid_vsync 0, cl_maxfps, etc. Fixes clean shutdown (config saving on `quit` works again). Removes code duplication and platform-specific ifdefs in host.c Signed-off-by: bones_was_here <[email protected]>
|
This is going to be merged one way or another eventually but we're moving at below glacial pace due to the nature of volunteer work (irl things taking precedence) and the complexity of implementing support for a new platform. General reminder not to feel discouraged. |
bones-was-here
suggested changes
Jul 24, 2024
There was a problem hiding this comment.
Could you fix all the compiler warnings in sys_wasm.c please? New code shouldn't have any warns.
Don't worry about the warns in other files, they're not caused by your code and are harmless (mostly unused variables due to compiling GLES, we can clean up GLES in another PR).
Signed-off-by: bones_was_here <[email protected]>
Signed-off-by: bones_was_here <[email protected]>
stringToNewUTF8() mallocs memory which must be free'd, and which doesn't need to be const (more convenient here). Signed-off-by: bones_was_here <[email protected]>
Signed-off-by: bones_was_here <[email protected]>
…terparts Signed-off-by: bones_was_here <[email protected]>
Most of these don't need to be declared for all compilation units. They're all FS commands. Signed-off-by: bones_was_here <[email protected]>
|
I have a bit more tidying and testing todo but then I think it'll be good to merge, planning to do that Sunday (unless someone finds an issue) |
Signed-off-by: bones_was_here <[email protected]>
Signed-off-by: bones_was_here <[email protected]>
bones-was-here
approved these changes
Aug 10, 2024
|
Great work guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webassembly version doesn’t work online and screen flashes on GLES2 are opaque.