Remove godotenv (which breaks dotenv) and build a macos arm version #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DarthSim -
a couple things here, and I didn't mess with tests, so very much assume this is not mergeable as is.... however.
the big thing is removing the
godotenv
module. the reason being,dotenv
allows you to overload -- so, you can define project envs in.env
, and say local overrides in.env.local
, for example. a nice way to prevent committing secrets.for safety, however, ruby's
dotenv
won't override existing env vars, typically those defined outside the scope of its runtime.godotenv
doesn't understand this functionality, so it's just loading.env
and nothing else -- and because those vars are defined before ruby starts, ruby'sdotenv
won't override them, and so local env settings are busted.tbh, i don't think it's appropriate for
hivemind
to be including them anyhow. if people want them and they're not already available, it's pretty easy to run a shell/pre-command to define the env within the Procfile... whereas being forced to define them viagodotenv
breaks things. hence the PR. :)also, i added a line to build a macos arm64 version, because m1.
hope it helps!