fix z-index - attempt 3 #31127
Merged
fix z-index - attempt 3 #31127
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Documentation Team ReviewThe documentation team has approved this pull request. Thank you for your contribution! |
brett0000FF
approved these changes
Aug 15, 2025
StefonSimmons
commented
Aug 15, 2025
| @@ -159,7 +159,7 @@ $tab-active-shadow: 0 -4px 12px rgba(99, 44, 166, 0.08); | |||
| background: #FFFFFF; | |||
| border: 1px solid $tab-border-color; | |||
| padding: 24px; | |||
| z-index: 1; | |||
| z-index: 0; | |||
There was a problem hiding this comment.
ensures the tab content is below the tabs. removes the bottom border of the active tab
nsollecito
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
3rd attempt at fixing the z-index for tabs.
Merge instructions
motivation: https://datadoghq.atlassian.net/browse/DOCSENG-113
previews: tabs should still work. design should be intact. there should be no tab that overlaps the leftnav search window
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes