-
Notifications
You must be signed in to change notification settings - Fork 1.2k
update log injection docs #31192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update log injection docs #31192
Conversation
✅ Documentation Team ReviewThe documentation team has approved this pull request. Thank you for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I added a couple of comments.
content/en/tracing/other_telemetry/connect_logs_and_traces/php.md
Outdated
Show resolved
Hide resolved
**Supported Input**: Boolean (`true`/`false`) <br> | ||
**Caveats**: Not supported in C++ or Go. The default value in Ruby is `true`.<br> | ||
**Caveats**: Not supported in C++ or Go.<br> | ||
**Description**: Enables or disables the automatic injection of trace context (trace ID, span ID) into application logs. This allows for correlation between traces and logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should clarify in the description that automatic injection is only for JSON/structured logs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mabdinur just a small suggestion, let me know when this is ready for re-review!
content/en/tracing/other_telemetry/connect_logs_and_traces/nodejs.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Alicia Scott <[email protected]> Co-authored-by: Duncan Hewett <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the updates looks good!
Log Injection is now enabled by default in the latest release of Datadog APM SDKs (except Go and C++ with do not support DD_LOGS_INJECTION configuration). This PR updates docs to reflect this.
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes