Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Go metric to metadata.csv #19314

Merged
merged 3 commits into from
Dec 27, 2024

Conversation

Kyle-Neale
Copy link
Contributor

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (eadaa1c) to head (701c723).
Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
supabase 93.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@steveny91
Copy link
Contributor

steveny91 commented Dec 27, 2024

@Kyle-Neale The test is failing. If you want to add these 2 metrics then I think you have to overwrite the type in the metrics.py

https://github.com/DataDog/integrations-core/blob/master/datadog_checks_base/datadog_checks/base/checks/openmetrics/v2/metrics.py#L4

@Kyle-Neale Kyle-Neale enabled auto-merge December 27, 2024 04:14
@Kyle-Neale Kyle-Neale added this pull request to the merge queue Dec 27, 2024
Merged via the queue into master with commit 7a9e725 Dec 27, 2024
40 of 41 checks passed
@Kyle-Neale Kyle-Neale deleted the kyle.neale/add-go-metric-supabase branch December 27, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants