[FIPS] Prefer warning over error #19465
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
iliakur
requested changes
Jan 27, 2025
| @@ -12,15 +15,15 @@ def enable_fips(path_to_openssl_conf=None, path_to_openssl_modules=None): | |||
| path_to_embedded = _get_embedded_path() if path_to_embedded is None else path_to_embedded | |||
| path_to_openssl_conf = path_to_embedded / "ssl" / "openssl.cnf" | |||
| if not path_to_openssl_conf.exists(): | |||
| raise RuntimeError(f'The configuration file "{path_to_openssl_conf}" does not exist') | |||
| LOGGER.warning('The configuration file "%s" does not exist', path_to_openssl_conf) | |||
There was a problem hiding this comment.
Here and below: let's decide between info and debug here. Some questions to help decide:
- Who's the target audience here? Is it a user who's just interested if their agent works? Or is it a user with a broken agent or (Support) engineer who is helping this user?
- If the config file doesn't exist, can we enable FIPS mode? Looks like we can...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged