fix: auto-pin race condition on go.mod file #521
Merged
+62
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `-toolexec` mode, the auto-pin process may be initiated by multiple concurrent executions of the `toolexec` proxy. In such cases, there is a race condition on access to `go.mod` and `orchestrion.tool.go`, which often results in `go mod tidy` failing due to it detecting concurrent modifications of the `go.mod` (it may also result in corrupt content of the `orchestrion.tool.go` file). This addresses the issue by having the auto-pin process acquire an advisory write lock on the `go.mod` file, making sure all attempts are properly synchronized, and only one attempt tries to modify the file at a time.
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…pin-race # Conflicts: # internal/pin/auto_test.go
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #521 +/- ##
==========================================
- Coverage 67.73% 63.84% -3.89%
==========================================
Files 106 106
Lines 6889 6899 +10
==========================================
- Hits 4666 4405 -261
- Misses 1744 2031 +287
+ Partials 479 463 -16
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
-toolexecmode, the auto-pin process may be initiated by multiple concurrent executions of thetoolexecproxy. In such cases, there is a race condition on access togo.modandorchestrion.tool.go, which often results ingo mod tidyfailing due to it detecting concurrent modifications of thego.mod(it may also result in corrupt content of theorchestrion.tool.gofile).This addresses the issue by having the auto-pin process acquire an advisory write lock on the
go.modfile, making sure all attempts are properly synchronized, and only one attempt tries to modify the file at a time.Fixes #491