chore(imports): Group local packages together #552
Conversation
Signed-off-by: Kemal Akkoyun <[email protected]>
github-actions
bot
added
the
conventional-commit/chore
There was a problem hiding this comment.
I personally don't see any benefits to adding a blank line between "local" and "not" package since they are sorted alphanumerically, so I can easily find an import or absence thereof without having the cognitive load to devise if this is repo-local or not... I am also partial to how my IDE behaves by default... because anything else is potentially additional barrier to contributions...
That said, I dont feel strongly enough on this subject to go all BDFL on this and impose my views... so I'll wait for more feedback on this proposal before deciding.
If you IDE support, golangci-lint config this should be automatic. Most of the IDEs, familiar with goimports settings.
👍 😊 I'm not attach to the idea at all. Let's see what others think. When it comes to automated static checks I'm a maximalist (if they are not slow), enable them all! |
goimportshas mode to group local imports together. Somehow this triggered my OCD 😅This is marked as draft to test the waters. Feel free to reject.
Signed-off-by: Kemal Akkoyun [email protected]