Skip to content

Commit

Permalink
Move docs to contributingGuides and help to docs
Browse files Browse the repository at this point in the history
  • Loading branch information
roryabraham committed Jul 6, 2022
1 parent 32e67da commit 7a67954
Show file tree
Hide file tree
Showing 46 changed files with 20 additions and 61 deletions.
31 changes: 0 additions & 31 deletions .github/workflows/deployHelpSite.yml

This file was deleted.

1 change: 0 additions & 1 deletion CLA.md

This file was deleted.

1 change: 0 additions & 1 deletion CONTRIBUTING.md

This file was deleted.

1 change: 0 additions & 1 deletion FORMS.md

This file was deleted.

1 change: 0 additions & 1 deletion HOW_TO_CREATE_A_PLAN.md

This file was deleted.

1 change: 0 additions & 1 deletion OfflineUX.md

This file was deleted.

1 change: 0 additions & 1 deletion PERFORMANCE.md

This file was deleted.

2 changes: 1 addition & 1 deletion PR_REVIEW_GUIDELINES.md
Original file line number Diff line number Diff line change
@@ -1 +1 @@
This file has been moved [here](./docs/PR_REVIEW_GUIDELINES.md).
This file has been moved [here](contributingGuides/PR_REVIEW_GUIDELINES.md).
16 changes: 8 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@
* [Deploying](#deploying)

#### Additional Reading
* [API Details](docs/API.md)
* [Offline First](./docs/OFFLINE_UX.md)
* [Contributing to Expensify](./docs/CONTRIBUTING.md)
* [Expensify Code of Conduct](./docs/CODE_OF_CONDUCT.md)
* [Contributor License Agreement](./docs/CLA.md)
* [API Details](contributingGuides/API.md)
* [Offline First](contributingGuides/OFFLINE_UX.md)
* [Contributing to Expensify](contributingGuides/CONTRIBUTING.md)
* [Expensify Code of Conduct](contributingGuides/CODE_OF_CONDUCT.md)
* [Contributor License Agreement](contributingGuides/CLA.md)

----

Expand Down Expand Up @@ -86,7 +86,7 @@ variables referenced here get updated since your local `.env` file is ignored.
requests to the backend. External contributors should set this to `true` otherwise they'll have CORS errors.
If you don't want to start the proxy server set this explicitly to `false`
- `CAPTURE_METRICS` (optional) - Set this to `true` to capture performance metrics and see them in Flipper
see [PERFORMANCE.md](./docs/PERFORMANCE.md#performance-metrics-opt-in-on-local-release-builds) for more information
see [PERFORMANCE.md](contributingGuides/PERFORMANCE.md#performance-metrics-opt-in-on-local-release-builds) for more information
- `ONYX_METRICS` (optional) - Set this to `true` to capture even more performance metrics and see them in Flipper
see [React-Native-Onyx#benchmarks](https://github.com/Expensify/react-native-onyx#benchmarks) for more information

Expand Down Expand Up @@ -286,9 +286,9 @@ This application is built with the following principles.
4. Brain pushes data into UI inputs (Device input -> React component).
5. UI inputs push data to the server (React component -> Action -> XHR to server).
6. Go to 1
![New Expensify Data Flow Chart](/docs/data_flow.png)
![New Expensify Data Flow Chart](/contributingGuides/data_flow.png)
1. **Offline first**
- Be sure to read [OFFLINE_UX.md](./docs/OFFLINE_UX.md)!
- Be sure to read [OFFLINE_UX.md](contributingGuides/OFFLINE_UX.md)!
- All data that is brought into the app and is necessary to display the app when offline should be stored on disk in persistent storage (eg. localStorage on browser platforms). [AsyncStorage](https://reactnative.dev/docs/asyncstorage) is a cross-platform abstraction layer that is used to access persistent storage.
- All data that is displayed, comes from persistent storage.
1. **UI Binds to data on disk**
Expand Down
1 change: 0 additions & 1 deletion STORYBOOK.md

This file was deleted.

1 change: 0 additions & 1 deletion STYLE.md

This file was deleted.

1 change: 0 additions & 1 deletion STYLING.md

This file was deleted.

1 change: 0 additions & 1 deletion TESTING_MACOS_AND_IOS.md

This file was deleted.

File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion docs/OFFLINE_UX.md → contributingGuides/OFFLINE_UX.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ This pattern blocks the user from interacting with an entire page.

The following flowchart can be used to determine which UX pattern should be used.

![New Expensify Data Flow Chart](/docs/OfflineUX_Patterns_Flowchart.png)
![New Expensify Data Flow Chart](/contributingGuides/OfflineUX_Patterns_Flowchart.png)

### Answering Questions on the Flow Chart

Expand Down
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
8 changes: 4 additions & 4 deletions help/README.md → docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ bundle install
# How the project is structured

The [help](https://github.com/Expensify/App/tree/e6cea38ef22f83ae4730a34a9281d8962388dff8/help) folder will contain the following main folders:
- *_layouts*: This contains HTML templates used by Jekyll to create pages in the static site. For now it has only one file ([default.html](https://github.com/Expensify/App/blob/e6cea38ef22f83ae4730a34a9281d8962388dff8/help/_layouts/default.html)) which will render the common HTML elements and the assets on every page. It also supports the use of the [liquid template language](https://shopify.github.io/liquid/).
- *_layouts*: This contains HTML templates used by Jekyll to create pages in the static site. For now it has only one file ([default.html](https://github.com/Expensify/App/blob/e6cea38ef22f83ae4730a34a9281d8962388dff8/docs/_layouts/default.html)) which will render the common HTML elements and the assets on every page. It also supports the use of the [liquid template language](https://shopify.github.io/liquid/).
- *_includes*: Contains HTML content that can be reused on different pages. For now, it contains various html elements that are used to populate the left-hand-nav (LHN).
- *assets*: it will contain the three sub-folders css, images, and js.
- The css folder can contain either .css or .sass files (where SASS files will be processed by Jekyll and it will generate a CSS file in an output folder also generated by Jekyll).
Expand All @@ -43,7 +43,7 @@ More details about the Jekyll project structure can be found [here](https://jeky

## Add content

Copy the [template](https://github.com/Expensify/App/blob/e6cea38ef22f83ae4730a34a9281d8962388dff8/help/TEMPLATE.md) file and rename it with the name of the article title, i.e. [SmartScan.md](https://github.com/Expensify/App/blob/e6cea38ef22f83ae4730a34a9281d8962388dff8/help/articles/request-money/request-money/SmartScan.md) (you can use dashes for spaces in the file name if it's needed) and put the new file inside of the respective hub folder or sub-folder. The title will be rendered automatically according to the filename (the dashes will be removed in the generated site page).
Copy the [template](https://github.com/Expensify/App/blob/e6cea38ef22f83ae4730a34a9281d8962388dff8/docs/TEMPLATE.md) file and rename it with the name of the article title, i.e. [SmartScan.md](https://github.com/Expensify/App/blob/e6cea38ef22f83ae4730a34a9281d8962388dff8/docs/articles/request-money/request-money/SmartScan.md) (you can use dashes for spaces in the file name if it's needed) and put the new file inside of the respective hub folder or sub-folder. The title will be rendered automatically according to the filename (the dashes will be removed in the generated site page).

The sections of the article will be filled and nested automatically in the LHN, just ensure to use the [heading markdown tags](https://www.markdownguide.org/cheat-sheet/) correctly.

Expand Down Expand Up @@ -110,7 +110,7 @@ If it's required, you can add a new row of Card buttons with the following HTML

A card button is the box that contains the article title and the caret right icon `>`. It navigates to the article when it's pressed.

In order to add a new Card button in the respective hub page ([send-money/index.html](https://github.com/Expensify/App/blob/e6cea38ef22f83ae4730a34a9281d8962388dff8/help/articles/send-money/index.html) or [request-money/index.html](https://github.com/Expensify/App/blob/e6cea38ef22f83ae4730a34a9281d8962388dff8/help/articles/request-money/index.html)) just copy and pase the following Card element:
In order to add a new Card button in the respective hub page ([send-money/index.html](https://github.com/Expensify/App/blob/e6cea38ef22f83ae4730a34a9281d8962388dff8/docs/articles/send-money/index.html) or [request-money/index.html](https://github.com/Expensify/App/blob/e6cea38ef22f83ae4730a34a9281d8962388dff8/docs/articles/request-money/index.html)) just copy and pase the following Card element:

```html
<div class="card" onclick="openArticle('./request-money/SmartScan')">
Expand Down Expand Up @@ -147,7 +147,7 @@ There are 2 main components in the LHN page associated with the hub you're addin

### Add a new Stage title anchor (optional)

Just add copy and paste the following HTML block in the corresponding navigation tree file (either for [Request Money](https://github.com/Expensify/App/blob/e6cea38ef22f83ae4730a34a9281d8962388dff8/help/_includes/request-money-navigation-tree.html) or [Send Money](https://github.com/Expensify/App/blob/e6cea38ef22f83ae4730a34a9281d8962388dff8/help/_includes/send-money-navigation-tree.html)):
Just add copy and paste the following HTML block in the corresponding navigation tree file (either for [Request Money](https://github.com/Expensify/App/blob/e6cea38ef22f83ae4730a34a9281d8962388dff8/docs/_includes/request-money-navigation-tree.html) or [Send Money](https://github.com/Expensify/App/blob/e6cea38ef22f83ae4730a34a9281d8962388dff8/docs/_includes/send-money-navigation-tree.html)):

```
<li><a href="#request-money">Request Money</a>
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<ul class="nested-treeview">

<!-- Add content below, more instructions in the README.md file
https://github.com/Expensify/App/blob/44b0fdad50da2c368e67ee6ae6951ad699f6125d/help/README.md#add-a-new-entry-in-the-lhn-and-hub-page
https://github.com/Expensify/App/blob/44b0fdad50da2c368e67ee6ae6951ad699f6125d/docs/README.md#add-a-new-entry-in-the-lhn-and-hub-page
-->

<!-- Stage title anchor -->
Expand All @@ -27,4 +27,4 @@
<!-- More Stage title anchors here... -->
</ul>
</li>
</ul>
</ul>
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
<ul class="nested-treeview">

<!-- Add content below, more instructions in the README.md file
https://github.com/Expensify/App/blob/44b0fdad50da2c368e67ee6ae6951ad699f6125d/help/README.md#add-a-new-entry-in-the-lhn-and-hub-page
https://github.com/Expensify/App/blob/44b0fdad50da2c368e67ee6ae6951ad699f6125d/docs/README.md#add-a-new-entry-in-the-lhn-and-hub-page
-->
</ul>
</li>
<li>
<i class="fa-solid fa-angle-right caret-icon"></i>
<a href="/hubs/request-money">Request Money</a>
</li>
</ul>
</ul>
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ <h1>
<!-- TODO: remove the following text, added just for testing -->
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Curabitur hendrerit euismod dui, nec fermentum urna porta ultrices. Nullam sed vestibulum purus, in auctor libero. Vestibulum ante ipsum primis in faucibus orci luctus et ultrices posuere cubilia Curae; Maecenas dolor metus,

<!-- Add content below, more instructions here https://github.com/Expensify/App/blob/2e1b8e9c20106484cacca813473946ab492d3f5b/help/README.md#add-a-new-entry-in-the-hub-page -->
<!-- Add content below, more instructions here https://github.com/Expensify/App/blob/2e1b8e9c20106484cacca813473946ab492d3f5b/docs/README.md#add-a-new-entry-in-the-hub-page -->

<!-- Stage title -->
<h2 id="request-money">
Expand Down
2 changes: 1 addition & 1 deletion help/hubs/send-money.html → docs/hubs/send-money.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ <h1>
<!-- TODO: remove the following text, added just for testing -->
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Curabitur hendrerit euismod dui, nec fermentum urna porta ultrices. Nullam sed vestibulum purus, in auctor libero. Vestibulum ante ipsum primis in faucibus orci luctus et ultrices posuere cubilia Curae; Maecenas dolor metus,

<!-- Add content below, more instructions here https://github.com/Expensify/App/blob/2e1b8e9c20106484cacca813473946ab492d3f5b/help/README.md#add-a-new-entry-in-the-hub-page -->
<!-- Add content below, more instructions here https://github.com/Expensify/App/blob/2e1b8e9c20106484cacca813473946ab492d3f5b/docs/README.md#add-a-new-entry-in-the-hub-page -->
File renamed without changes.

0 comments on commit 7a67954

Please sign in to comment.