Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return port number or zero otherwise in forward command #457

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yotamN
Copy link

@yotamN yotamN commented Jun 11, 2023

Fixes #456

@koral--
Copy link
Member

koral-- commented Jun 12, 2023

Your PR does not pass the checks.

@denis99999
Copy link

It should not break backward compatibility

@yotamN
Copy link
Author

yotamN commented Jun 12, 2023

I will make sure it passes the tests but regarding backward compatibility, I'm not sure how you want me to do it.
I must change the return value, so my options are:

  • Create a new function and deprecate the old one, how would I call it?
  • Keep returning null unless there's a port and than return the port (which is truthful)
  • Extend the boolean object with getPort or something, the most awful solution IMO.

@yotamN yotamN force-pushed the feature/forward-port-value branch from 66fe5c9 to d483403 Compare June 13, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forward command doesn't return the resolved tcp port
4 participants