Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature - read dev users from file #396

Merged
merged 6 commits into from
Oct 10, 2024
Merged

feature - read dev users from file #396

merged 6 commits into from
Oct 10, 2024

Conversation

MarcelWildenburg
Copy link
Contributor

@MarcelWildenburg MarcelWildenburg commented Sep 27, 2024 •
edited
Loading

Extend functionality for creating dev users with a file so every developer can use its one users.

@MarcelWildenburg MarcelWildenburg marked this pull request as draft September 27, 2024 21:13
@github-actions GitHub Actions
Copy link

Overall Project 72.11% -2.17% 🍏
Files changed 0% 🍏

File Coverage
ApplicationLifeCycle.java 14.94% -32.66% 🍏

@MarcelWildenburg MarcelWildenburg marked this pull request as ready for review September 28, 2024 19:42
@github-actions GitHub Actions
Copy link

Overall Project 72.11% -2.17% 🍏
Files changed 0% 🍏

File Coverage
ApplicationLifeCycle.java 14.94% -32.66% 🍏

LDMGN
LDMGN reviewed Oct 9, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
src/main/java/org/littil/api/ApplicationLifeCycle.java Outdated Show resolved Hide resolved
src/main/java/org/littil/api/ApplicationLifeCycle.java Outdated Show resolved Hide resolved
src/main/java/org/littil/api/ApplicationLifeCycle.java Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

Overall Project 72.48% -1.66% 🍏
Files changed 0% 🍏

File Coverage
ApplicationLifeCycle.java 16.21% -26.92% 🍏

@MarcelWildenburg MarcelWildenburg requested a review from LDMGN October 9, 2024 18:06
tubbynl
tubbynl approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@tubbynl tubbynl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, handy to add extra local dev users

@github-actions GitHub Actions
Copy link

Overall Project 72.57% -1.54% 🍏
Files changed 0% 🍏

File Coverage
ApplicationLifeCycle.java 16.53% -25.49% 🍏

@MarcelWildenburg MarcelWildenburg merged commit 9ec65bd into main Oct 10, 2024
4 checks passed
@MarcelWildenburg MarcelWildenburg deleted the feature/read-dev-users-from-file branch October 10, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tubbynl tubbynl tubbynl approved these changes

@pschildkamp pschildkamp Awaiting requested review from pschildkamp

@LDMGN LDMGN Awaiting requested review from LDMGN

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcelWildenburg @LDMGN @tubbynl