Skip to content

Commit

Permalink
nit in console interrupts
Browse files Browse the repository at this point in the history
  • Loading branch information
kaashoek committed Sep 7, 2006
1 parent d6b2025 commit f9bc445
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
5 changes: 3 additions & 2 deletions Notes
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,10 @@ test: deadlock d/.. vs ../d, two processes.
test: dup() shared fd->off
test: does echo foo > x truncate x?

sh: support pipes? leave it for the class?
sh: ioredirection incorrect now we have pipes
sh: chain of pipes won't work, also ugly that parent closes fdarray entries too
sh: dynamic memory allocation?
sh: should sh support ; () & --- need malloc
sh: should sh support ; () &
sh: stop stdin on ctrl-d (for cat > y)

really should have bdwrite() for file content
Expand Down
1 change: 0 additions & 1 deletion console.c
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@ console_write(int minor, char *buf, int n)
}


// This is i8042reg.h + kbdreg.h from NetBSD.
#define KBSTATP 0x64 // kbd controller status port(I)
#define KBS_DIB 0x01 // kbd data in buffer
#define KBDATAP 0x60 // kbd data port(I)
Expand Down

0 comments on commit f9bc445

Please sign in to comment.