Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use Elixir DateTime module with time zone suppport #153

Merged
merged 5 commits into from
Aug 1, 2023

Conversation

andrewtimberlake
Copy link
Collaborator

I have updated both the parser and render to use Elixir’s DateTime module
This allows us to correctly parse time zone offsets in timestamps
The renderer still accepts erl timestamp tuples, assumed to be UTC
If a DateTime is supplied, and it has time zone information, that will be used in rendering.
Parsing now returns DateTime objects in UTC based on the supplied time zone offset of the timestamp (a breaking change)

I have also fixed compile warnings.
This moves the minimum Elixir requirement to 1.10

@bcardarella
Copy link
Member

This is great :)

@andrewtimberlake andrewtimberlake merged commit 7fa8f4b into DockYard:master Aug 1, 2023
@andrewtimberlake andrewtimberlake deleted the date-time branch August 1, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants