Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 8-bit decoding to preserve line breaks but restore wrapped lines #166

Merged

Conversation

andrewtimberlake
Copy link
Collaborator

The current implementation of 8-bit encoding wraps lines longer than 998, as it should, but then removes all line breaks on decoding—but it should only remove those added due to line wrapping.
This pull request also validates the character set by raising on a null character in the same way the encoding does.
Because of the change in decoding, this is a breaking change (But we haven’t released the version increase from the 7-bit decoding fix #164 so there’s no need for a further version increase.)

@andrewtimberlake andrewtimberlake merged commit 07f2d29 into DockYard:master Aug 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant