Auto format arquero tables into HTML (#27)

DonJayamanne · Sep 6, 2021 · 6cb9d33 · 6cb9d33
1 parent 0bd5908
commit 6cb9d33
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/src/extension/kernel/problems.ts b/src/extension/kernel/problems.ts
@@ -10,6 +10,7 @@ import {
 import { IDisposable } from '../types';
 import { disposeAllDisposables } from '../utils';
 import { parse as parseStack } from 'error-stack-parser';
+import type ErrorStackParser from 'error-stack-parser';
 import { Compiler } from './compiler';
 
 const diagnosticsCollection = languages.createDiagnosticCollection('Typscript Notebook');
@@ -35,7 +36,14 @@ export class CellDiagnosticsProvider {
         if (!ex || !ex?.stack) {
             return;
         }
-        const stacks = parseStack(ex as Error);
+        let stacks: ErrorStackParser.StackFrame[] = [];
+        try {
+            stacks = parseStack(ex as Error);
+        } catch (ex) {
+            // TODO: Seems to fail in windows.
+            console.error('Failed to parse Stack trace', ex);
+            return;
+        }
         if (stacks.length === 0) {
             return;
         }

diff --git a/src/extension/server/extensions/arqueroFormatter.ts b/src/extension/server/extensions/arqueroFormatter.ts
@@ -1,10 +1,21 @@
 export class ArqueroFormatter {
+    private static arqueroTable?: any;
+    public static isArqueroTable(table: any) {
+        try {
+            const proto = table.__proto__ || table.prototype;
+            return proto && ArqueroFormatter.arqueroTable === proto;
+        } catch {
+            //
+        }
+        return false;
+    }
     public static initialize(arquero: typeof import('arquero')) {
         var table = arquero.table({ colA: ['a', 'b', 'c'], colB: [3, 4, 5] });
         const proto = (table as any).__proto__ || (table as any).protptype;
         if (!proto) {
             return;
         }
+        ArqueroFormatter.arqueroTable = proto;
         proto.print = function (opts) {
             const { display } = require('node-kernel');
             display.html(this.toHTML(opts));

diff --git a/src/extension/server/extensions/format.ts b/src/extension/server/extensions/format.ts
@@ -6,6 +6,7 @@ import { logMessage } from '../logger';
 import { DisplayData } from '../types';
 import { DanfoJsFormatter } from './danfoFormatter';
 import { formatTensor, isTensor } from './tensorFormatter';
+import { ArqueroFormatter } from './arqueroFormatter';
 
 export function isBase64OrSvg(value: string) {
     return value.startsWith('data:image/') || (value.endsWith('</svg>') && value.includes('<svg'));
@@ -37,6 +38,12 @@ export async function formatImage(
 export async function formatValue(value: unknown, requestId: string): Promise<DisplayData | undefined> {
     if (typeof value === undefined) {
         return;
+    } else if (ArqueroFormatter.isArqueroTable(value)) {
+        return {
+            type: 'html',
+            requestId,
+            value: (value as any).toHTML()
+        };
     } else if (typeof value === 'string' && value.startsWith('data:image/')) {
         return {
             type: 'multi-mime',