Merge pull request rubyforgood#241 from rubyforgood/deprecations

this fixes the deprecation warnings with rubocop and rpsec
DouglasLutz · Oct 22, 2019 · 9d3d053 · 9d3d053
2 parents e88d461 + 08d28e9
commit 9d3d053
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/Gemfile b/Gemfile
@@ -38,6 +38,7 @@ group :development, :test do
  gem "pry-remote"
  gem "rspec-rails", "~> 3.5"
  gem "rubocop"
+ gem "rubocop-rspec"
  gem "simplecov", require: false
 end
 

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -316,6 +316,8 @@ GEM
  rainbow (>= 2.2.2, < 4.0)
  ruby-progressbar (~> 1.7)
  unicode-display_width (~> 1.4.0)
+ rubocop-rspec (1.35.0)
+ rubocop (>= 0.60.0)
  ruby-progressbar (1.10.0)
  ruby_dep (1.5.0)
  rubyzip (1.3.0)
@@ -442,6 +444,7 @@ DEPENDENCIES
  rails (~> 5.2.1)
  rspec-rails (~> 3.5)
  rubocop
+ rubocop-rspec
  sass-rails (~> 5.0)
  selenium-webdriver
  shoulda-matchers

diff --git a/spec/factories/item_requests.rb b/spec/factories/item_requests.rb
@@ -23,7 +23,7 @@
  # This is loaded before the database and migratinos are run. If we use
  # Child.new it doesn't allow the db to be created.
  # TODO: Figure out what's going on here.
- child OpenStruct.new
+ child { OpenStruct.new }
  # child OpenStruct.new
  end
 

diff --git a/spec/factories/partner_requests.rb b/spec/factories/partner_requests.rb
@@ -33,7 +33,7 @@
 
  factory :partner_request_for_families do
  transient do
- children []
+ children { [] }
  item_requests_count { 2 }
  end