Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Support for other languages #27

Merged
merged 1 commit into from
Jul 13, 2023
Merged

[Feature Request] Support for other languages #27

merged 1 commit into from
Jul 13, 2023

Conversation

winterborn
Copy link
Contributor

@winterborn winterborn commented Jul 13, 2023 •
edited
Loading

  • Completed the extraction of the language code and processed this by associated filters.
  • Tested this with a very rudimentary subtitle.de.srt file.
  • Have not handled passing of --lang parameter

@winterborn winterborn changed the title Handled extracted language codes and provided rudimentary de-main.json file. [Feature Request] Support for other languages Jul 13, 2023
@DrKain
Copy link
Owner

DrKain commented Jul 13, 2023

Would you mind changing the branch to dev?

@winterborn winterborn changed the base branch from main to dev July 13, 2023 20:43
@DrKain DrKain merged commit cc88eae into DrKain:dev Jul 13, 2023
@DrKain
Copy link
Owner

DrKain commented Jul 13, 2023

Thank you

@DrKain DrKain mentioned this pull request Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winterborn @DrKain