Today I Learnt: you can't check consts for empty

Doesn't work at all, interestingly for different reasons across PHP versions - http://3v4l.org/06f2E
Duke3D · May 25, 2015 · 1921d0f · 1921d0f
1 parent 6358215
commit 1921d0f
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/includes/functions-http.php b/includes/functions-http.php
@@ -76,9 +76,8 @@ function yourls_http_post_body( $url, $headers = array(), $data = array(), $opti
 function yourls_http_get_proxy() {
     $proxy = false;
 
-    if( defined( 'YOURLS_PROXY' ) && !empty( YOURLS_PROXY ) ) {
+    if( defined( 'YOURLS_PROXY' ) ) {
         $proxy = YOURLS_PROXY;
-        // Username (?) and password can be defined as an empty string : no check for empty()
         if( defined( 'YOURLS_PROXY_USERNAME' ) && defined( 'YOURLS_PROXY_PASSWORD' ) ) {
             $proxy = array( YOURLS_PROXY, YOURLS_PROXY_USERNAME, YOURLS_PROXY_PASSWORD );
         }