CommandEnum: specify enumValues type

phpstan 0.12.26 starts reporting errors about the result of array_search() being given to some constructor or another because of the lack of key type specification.
DylanMarkon · Jun 10, 2020 · fcc9e62 · fcc9e62
1 parent 4261361
commit fcc9e62
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/pocketmine/Player.php b/src/pocketmine/Player.php
@@ -172,6 +172,7 @@
 use pocketmine\utils\UUID;
 use function abs;
 use function array_merge;
+use function array_values;
 use function assert;
 use function base64_decode;
 use function ceil;
@@ -742,7 +743,7 @@ public function sendCommandData(){
 				}
 				$data->aliases = new CommandEnum();
 				$data->aliases->enumName = ucfirst($command->getName()) . "Aliases";
-				$data->aliases->enumValues = $aliases;
+				$data->aliases->enumValues = array_values($aliases);
 			}
 
 			$pk->commandData[$command->getName()] = $data;

diff --git a/src/pocketmine/network/mcpe/protocol/types/CommandEnum.php b/src/pocketmine/network/mcpe/protocol/types/CommandEnum.php
@@ -26,7 +26,10 @@
 class CommandEnum{
 	/** @var string */
 	public $enumName;
-	/** @var string[] */
+	/**
+	 * @var string[]
+	 * @phpstan-var list<string>
+	 */
 	public $enumValues = [];
 
 }