[DRAFT]: add option for writing to stdout #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is more of a proof of concept (a working one). I do have some question regarding how to implement this. Since a lot of the function are tightly coupled to path, there's a lot of rewrite need to be done. Should i make another set of funtion just for writing to async write so the original public facing api doesnt change or should i rewrite it to use async write only, but we will loose the ability to give information about whre the file is donwloaded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now this pr is a draft.
rustube right now only able to write to file. This pr added the ability to write to async write trait.
solves #59