Rm getters setters #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tomdcsmith
commented
Apr 15, 2016
tomdcsmith
commented
- Most getters and setters changed to properties and property setters using decorators
- Completed tests
… use as regular attributes.
…eline into rm_getters_setters Conflicts: .gitignore
…itten most tests for CTTVSomaticEvidenceString class.
…e strings json. - Removed set_unique_association_field, identical code to add_unique_association_field, and not used in code.
- Changed so_name to property. - Test of processgene and ProcessConsequenceTypeFileTsv
-SOTerm tests
-Removed unused get_so_accessions -most_severse_so as property -Consequence type tests
…eline into rm_getters_setters
|
I'm not sure why, but a couple of tests are passing when I run them locally, but when travis runs them they fail. |
| @@ -3,37 +3,9 @@ | |||
| __author__ = 'Javier Lopez: [email protected]' | |||
|
|
|||
|
|
|||
| def _process_consequence_type_file_xls(snp_2_gene_file): | |||
There was a problem hiding this comment.
Is this intentional? It is not related to getter/setter removal.
There was a problem hiding this comment.
This was removed because the latest file provided by CTTV was in tsv format, so this is now possibly redundant. If they provide a file in xls format in the future this can be added back, but I think the reason this was in xls format initially was because a tsv file was put into xls format. If this is incorrect and they do provide a xls file in the future then the actual data is simple enough to just change to a tsv file, which keeps the code simpler.
tomdcsmith
pushed a commit
to tomdcsmith/eva-cttv-pipeline
that referenced
this pull request
May 23, 2016
Getters and setters replaced by properties
tomdcsmith
pushed a commit
to tomdcsmith/eva-cttv-pipeline
that referenced
this pull request
Aug 1, 2016
Getters and setters replaced by properties
tomdcsmith
pushed a commit
to tomdcsmith/eva-cttv-pipeline
that referenced
this pull request
Aug 1, 2016
Getters and setters replaced by properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.