Remove quote around $INPUT_PRETTIER_FLAGS to pass flags correctly #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokoucha
force-pushed
the
fix-prettier-flags-quoting
branch
from
550df9c to
b9b30a5
Compare
|
I'd love to see this integrated |
|
Would love to see this one merged as well. Was banging my head against this for hours trying to figure out why I couldn't run the action with a list of changed files and it's because of the quoting. EDIT: Looks like the quotes were added because of shellcheck linting: 64e7c93 .. oh the irony of it all :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to use reviewdog-action-prettier in my project which uses yarn workspaces but It did not work as expected because the prettier_flags option will be passed to prettier as concreted to one argument.
This PR fixes an issue where prettier_flags were incorrectly passed without being split.