pkp/pkp-lib#6092 Move PKPApplication constants into class

Edgarchica · Mar 8, 2021 · 0bdc502 · 0bdc502
1 parent c8a5d8b
commit 0bdc502
Show file tree

Hide file tree

Showing 69 changed files with 132 additions and 128 deletions.
diff --git a/classes/components/forms/FieldSelectIssue.inc.php b/classes/components/forms/FieldSelectIssue.inc.php
@@ -30,7 +30,7 @@ public function getConfig() {
 
  $issueUrlPlaceholder = \Application::get()->getRequest()->getDispatcher()->url(
  \Application::get()->getRequest(),
- ROUTE_PAGE,
+ PKPApplication::ROUTE_PAGE,
  null,
  'issue',
  'view',

diff --git a/classes/components/listPanels/SubmissionsListPanel.inc.php b/classes/components/listPanels/SubmissionsListPanel.inc.php
@@ -41,7 +41,7 @@ public function getConfig() {
  $issueAutosuggestField = new FieldSelectIssues('issueIds', [
  'label' => __('issue.issues'),
  'value' => [],
- 'apiUrl' => $request->getDispatcher()->url($request, ROUTE_API, $request->getContext()->getPath(), 'issues'),
+ 'apiUrl' => $request->getDispatcher()->url($request, PKPApplication::ROUTE_API, $request->getContext()->getPath(), 'issues'),
  ]);
  $config['filters'][] = [
  'filters' => [

diff --git a/classes/controllers/grid/issues/IssueGridHandler.inc.php b/classes/controllers/grid/issues/IssueGridHandler.inc.php
@@ -421,7 +421,7 @@ function issueGalleys($args, $request) {
  return $templateMgr->fetchAjax(
  'issueGalleysGridContainer',
  $dispatcher->url(
- $request, ROUTE_COMPONENT, null,
+ $request, PKPApplication::ROUTE_COMPONENT, null,
  'grid.issueGalleys.IssueGalleyGridHandler', 'fetchGrid', null,
  array('issueId' => $issue->getId())
  )

diff --git a/classes/notification/NotificationManager.inc.php b/classes/notification/NotificationManager.inc.php
@@ -35,7 +35,7 @@ function getNotificationUrl($request, $notification) {
 
  switch ($notification->getType()) {
  case NOTIFICATION_TYPE_PUBLISHED_ISSUE:
- return $dispatcher->url($request, ROUTE_PAGE, $context->getPath(), 'issue', 'current');
+ return $dispatcher->url($request, PKPApplication::ROUTE_PAGE, $context->getPath(), 'issue', 'current');
  default:
  return parent::getNotificationUrl($request, $notification);
  }

diff --git a/classes/payment/ojs/OJSPaymentManager.inc.php b/classes/payment/ojs/OJSPaymentManager.inc.php
@@ -57,24 +57,24 @@ function createQueuedPayment($request, $type, $userId, $assocId, $amount, $curre
 
  switch ($type) {
  case PAYMENT_TYPE_PURCHASE_ARTICLE:
- $payment->setRequestUrl($dispatcher->url($request, ROUTE_PAGE, null, 'article', 'view', $assocId));
+ $payment->setRequestUrl($dispatcher->url($request, PKPApplication::ROUTE_PAGE, null, 'article', 'view', $assocId));
  break;
  case PAYMENT_TYPE_PURCHASE_ISSUE:
- $payment->setRequestUrl($dispatcher->url($request, ROUTE_PAGE, null, 'issue', 'view', $assocId));
+ $payment->setRequestUrl($dispatcher->url($request, PKPApplication::ROUTE_PAGE, null, 'issue', 'view', $assocId));
  break;
  case PAYMENT_TYPE_PURCHASE_SUBSCRIPTION:
- $payment->setRequestUrl($dispatcher->url($request, ROUTE_PAGE, null, 'issue', 'current'));
+ $payment->setRequestUrl($dispatcher->url($request, PKPApplication::ROUTE_PAGE, null, 'issue', 'current'));
  break;
  case PAYMENT_TYPE_RENEW_SUBSCRIPTION:
- $payment->setRequestUrl($dispatcher->url($request, ROUTE_PAGE, null, 'user', 'subscriptions'));
+ $payment->setRequestUrl($dispatcher->url($request, PKPApplication::ROUTE_PAGE, null, 'user', 'subscriptions'));
  break;
  case PAYMENT_TYPE_PUBLICATION:
  $submissionDao = DAORegistry::getDAO('SubmissionDAO'); /* @var $submissionDao SubmissionDAO */
  $submission = $submissionDao->getById($assocId);
  if ($submission->getSubmissionProgress()!=0) {
- $payment->setRequestUrl($dispatcher->url($request, ROUTE_PAGE, null, 'submission', 'wizard', $submission->getSubmissionProgress(), array('submissionId' => $assocId)));
+ $payment->setRequestUrl($dispatcher->url($request, PKPApplication::ROUTE_PAGE, null, 'submission', 'wizard', $submission->getSubmissionProgress(), array('submissionId' => $assocId)));
  } else {
- $payment->setRequestUrl($dispatcher->url($request, ROUTE_PAGE, null, 'authorDashboard', 'submission', $submission->getId()));
+ $payment->setRequestUrl($dispatcher->url($request, PKPApplication::ROUTE_PAGE, null, 'authorDashboard', 'submission', $submission->getId()));
  }
  break;
  case PAYMENT_TYPE_MEMBERSHIP: // Deprecated

diff --git a/classes/services/GalleyService.inc.php b/classes/services/GalleyService.inc.php
@@ -117,7 +117,7 @@ public function getProperties($galley, $props, $args = null) {
  if (is_a($galley, 'IssueGalley')) {
  $values[$prop] = $dispatcher->url(
  $request,
- ROUTE_PAGE,
+ PKPApplication::ROUTE_PAGE,
  $context->getPath(),
  'issue',
  'view',
@@ -129,7 +129,7 @@ public function getProperties($galley, $props, $args = null) {
  } else {
  $values[$prop] = $dispatcher->url(
  $request,
- ROUTE_PAGE,
+ PKPApplication::ROUTE_PAGE,
  $context->getPath(),
  'article',
  'view',

diff --git a/classes/services/IssueService.inc.php b/classes/services/IssueService.inc.php
@@ -204,7 +204,7 @@ public function getProperties($issue, $props, $args = null) {
  $arguments = $route->getArguments();
  $values[$prop] = $dispatcher->url(
  $args['request'],
- ROUTE_API,
+ PKPApplication::ROUTE_API,
  $arguments['contextPath'],
  'issues/' . $issue->getId()
  );
@@ -245,7 +245,7 @@ public function getProperties($issue, $props, $args = null) {
  if ($context) {
  $values[$prop] = $dispatcher->url(
  $request,
- ROUTE_PAGE,
+ PKPApplication::ROUTE_PAGE,
  $context->getPath(),
  'issue',
  'view',

diff --git a/classes/services/NavigationMenuService.inc.php b/classes/services/NavigationMenuService.inc.php
@@ -113,7 +113,7 @@ function getDisplayStatusCallback($hookName, $args) {
  case NMI_TYPE_CURRENT:
  $navigationMenuItem->setUrl($dispatcher->url(
  $request,
- ROUTE_PAGE,
+ PKPApplication::ROUTE_PAGE,
  null,
  'issue',
  'current',
@@ -123,7 +123,7 @@ function getDisplayStatusCallback($hookName, $args) {
  case NMI_TYPE_ARCHIVES:
  $navigationMenuItem->setUrl($dispatcher->url(
  $request,
- ROUTE_PAGE,
+ PKPApplication::ROUTE_PAGE,
  null,
  'issue',
  'archive',
@@ -133,7 +133,7 @@ function getDisplayStatusCallback($hookName, $args) {
  case NMI_TYPE_SUBSCRIPTIONS:
  $navigationMenuItem->setUrl($dispatcher->url(
  $request,
- ROUTE_PAGE,
+ PKPApplication::ROUTE_PAGE,
  null,
  'about',
  'subscriptions',
@@ -143,7 +143,7 @@ function getDisplayStatusCallback($hookName, $args) {
  case NMI_TYPE_MY_SUBSCRIPTIONS:
  $navigationMenuItem->setUrl($dispatcher->url(
  $request,
- ROUTE_PAGE,
+ PKPApplication::ROUTE_PAGE,
  null,
  'user',
  'subscriptions',

diff --git a/classes/services/PublicationService.inc.php b/classes/services/PublicationService.inc.php
@@ -76,7 +76,7 @@ function($galley) use ($dependencies) {
  case 'urlPublished':
  $values[$prop] = $dispatcher->url(
  $request,
- ROUTE_PAGE,
+ PKPApplication::ROUTE_PAGE,
  $submissionContext->getData('urlPath'),
  'article',
  'view',

diff --git a/classes/services/SubmissionService.inc.php b/classes/services/SubmissionService.inc.php
@@ -160,7 +160,7 @@ public function modifyPropertyValues($hookName, $args) {
  case 'urlPublished':
  $values[$prop] = $dispatcher->url(
  $request,
- ROUTE_PAGE,
+ PKPApplication::ROUTE_PAGE,
  $context->getPath(),
  'article',
  'view',

diff --git a/config.TEMPLATE.inc.php b/config.TEMPLATE.inc.php
@@ -31,6 +31,10 @@
 ; The canonical URL to the OJS installation (excluding the trailing slash)
 base_url = "http://pkp.sfu.ca/ojs"
 
+; Enable strict mode. This will more aggressively cause errors/warnings when
+; deprecated behaviour exists in the codebase.
+strict = Off
+
 ; Session cookie name
 session_cookie_name = OJSSID
 

diff --git a/controllers/grid/articleGalleys/ArticleGalleyGridHandler.inc.php b/controllers/grid/articleGalleys/ArticleGalleyGridHandler.inc.php
@@ -429,7 +429,7 @@ public function canEdit() {
  return $this->getPublication()->getData('status') !== STATUS_PUBLISHED &&
  Services::get('user')->canUserAccessStage(
  WORKFLOW_STAGE_ID_PRODUCTION,
- WORKFLOW_TYPE_EDITORIAL,
+ PKPApplication::WORKFLOW_TYPE_EDITORIAL,
  $this->getAuthorizedContextObject(ASSOC_TYPE_ACCESSIBLE_WORKFLOW_STAGES),
  $this->getAuthorizedContextObject(ASSOC_TYPE_USER_ROLES)
  );

diff --git a/controllers/grid/issues/IssueGridRow.inc.php b/controllers/grid/issues/IssueGridRow.inc.php
@@ -53,7 +53,7 @@ function initialize($request, $template = null) {
  new LinkAction(
  $issue->getDatePublished()?'viewIssue':'previewIssue',
  new OpenWindowAction(
- $dispatcher->url($request, ROUTE_PAGE, null, 'issue', 'view', array($issueId))
+ $dispatcher->url($request, PKPApplication::ROUTE_PAGE, null, 'issue', 'view', array($issueId))
  ),
  __($issue->getDatePublished()?'grid.action.viewIssue':'grid.action.previewIssue'),
  'information'

diff --git a/controllers/grid/pubIds/PubIdExportIssuesListGridCellProvider.inc.php b/controllers/grid/pubIds/PubIdExportIssuesListGridCellProvider.inc.php
@@ -53,7 +53,7 @@ function getCellActions($request, $row, $column, $position = GRID_ACTION_POSITIO
  new LinkAction(
  'edit',
  new AjaxModal(
- $dispatcher->url($request, ROUTE_COMPONENT, null, 'grid.issues.BackIssueGridHandler', 'editIssue', null, array('issueId' => $publishedIssue->getId())),
+ $dispatcher->url($request, PKPApplication::ROUTE_COMPONENT, null, 'grid.issues.BackIssueGridHandler', 'editIssue', null, array('issueId' => $publishedIssue->getId())),
  __('plugins.importexport.common.settings.DOIPluginSettings')
  ),
  htmlspecialchars($publishedIssue->getIssueIdentification()),

diff --git a/controllers/grid/pubIds/PubIdExportRepresentationsListGridCellProvider.inc.php b/controllers/grid/pubIds/PubIdExportRepresentationsListGridCellProvider.inc.php
@@ -77,7 +77,7 @@ function getCellActions($request, $row, $column, $position = GRID_ACTION_POSITIO
  new LinkAction(
  'edit',
  new AjaxModal(
- $dispatcher->url($request, ROUTE_COMPONENT, null, 'grid.issues.BackIssueGridHandler', 'editIssue', null, array('issueId' => $issue->getId())),
+ $dispatcher->url($request, PKPApplication::ROUTE_COMPONENT, null, 'grid.issues.BackIssueGridHandler', 'editIssue', null, array('issueId' => $issue->getId())),
  __('plugins.importexport.common.settings.DOIPluginSettings')
  ),
  htmlspecialchars($issue->getIssueIdentification()),

diff --git a/controllers/grid/submissions/ExportPublishedSubmissionsListGridCellProvider.inc.php b/controllers/grid/submissions/ExportPublishedSubmissionsListGridCellProvider.inc.php
@@ -75,7 +75,7 @@ function getCellActions($request, $row, $column, $position = GRID_ACTION_POSITIO
  new LinkAction(
  'edit',
  new AjaxModal(
- $dispatcher->url($request, ROUTE_COMPONENT, null, 'grid.issues.BackIssueGridHandler', 'editIssue', null, array('issueId' => $issue->getId())),
+ $dispatcher->url($request, PKPApplication::ROUTE_COMPONENT, null, 'grid.issues.BackIssueGridHandler', 'editIssue', null, array('issueId' => $issue->getId())),
  __('plugins.importexport.common.settings.DOIPluginSettings')
  ),
  htmlspecialchars($issue->getIssueIdentification()),

diff --git a/controllers/grid/toc/TocGridRow.inc.php b/controllers/grid/toc/TocGridRow.inc.php
@@ -43,7 +43,7 @@ function initialize($request, $template = null) {
  new LinkAction(
  'workflow',
  new RedirectAction(
- $dispatcher->url($request, ROUTE_PAGE, null, 'workflow', 'access', array($this->getId()))
+ $dispatcher->url($request, PKPApplication::ROUTE_PAGE, null, 'workflow', 'access', array($this->getId()))
  ),
  __('submission.submission'),
  'information'

diff --git a/controllers/modals/publish/AssignToIssueHandler.inc.php b/controllers/modals/publish/AssignToIssueHandler.inc.php
@@ -81,7 +81,7 @@ function assign($args, $request) {
  $submissionContext = Services::get('context')->get($this->submission->getData('contextId'));
  }
 
- $publicationApiUrl = $request->getDispatcher()->url($request, ROUTE_API, $submissionContext->getPath(), 'submissions/' . $this->submission->getId() . '/publications/' . $this->publication->getId());
+ $publicationApiUrl = $request->getDispatcher()->url($request, PKPApplication::ROUTE_API, $submissionContext->getPath(), 'submissions/' . $this->submission->getId() . '/publications/' . $this->publication->getId());
  $assignToIssueForm = new APP\components\forms\publication\AssignToIssueForm($publicationApiUrl, $this->publication, $submissionContext);
  $settingsData = [
  'components' => [

diff --git a/controllers/tab/workflow/WorkflowTabHandler.inc.php b/controllers/tab/workflow/WorkflowTabHandler.inc.php
@@ -34,7 +34,7 @@ function fetchTab($args, $request) {
  'schedulePublication',
  new AjaxModal(
  $dispatcher->url(
- $request, ROUTE_COMPONENT, null,
+ $request, PKPApplication::ROUTE_COMPONENT, null,
  'tab.issueEntry.IssueEntryTabHandler',
  'publicationMetadata', null,
  array('submissionId' => $submission->getId(), 'stageId' => $stageId)

diff --git a/pages/article/ArticleHandler.inc.php b/pages/article/ArticleHandler.inc.php
@@ -275,7 +275,7 @@ function view($args, $request) {
  // Ask robots not to index outdated versions and point to the canonical url for the latest version
  if ($publication->getId() !== $article->getCurrentPublication()->getId()) {
  $templateMgr->addHeader('noindex', '<meta name="robots" content="noindex">');
- $url = $request->getDispatcher()->url($request, ROUTE_PAGE, null, 'article', 'view', $article->getBestId());
+ $url = $request->getDispatcher()->url($request, PKPApplication::ROUTE_PAGE, null, 'article', 'view', $article->getBestId());
  $templateMgr->addHeader('canonical', '<link rel="canonical" href="' . $url . '">');
  }
 

diff --git a/pages/authorDashboard/AuthorDashboardHandler.inc.php b/pages/authorDashboard/AuthorDashboardHandler.inc.php
@@ -24,7 +24,7 @@ class AuthorDashboardHandler extends PKPAuthorDashboardHandler {
  protected function _getRepresentationsGridUrl($request, $submission) {
  return $request->getDispatcher()->url(
  $request,
- ROUTE_COMPONENT,
+ PKPApplication::ROUTE_COMPONENT,
  null,
  'grid.articleGalleys.ArticleGalleyGridHandler',
  'fetchGrid',

diff --git a/pages/management/SettingsHandler.inc.php b/pages/management/SettingsHandler.inc.php
@@ -61,7 +61,7 @@ function distribution($args, $request) {
  $router = $request->getRouter();
  $dispatcher = $request->getDispatcher();
 
- $apiUrl = $dispatcher->url($request, ROUTE_API, $context->getPath(), 'contexts/' . $context->getId());
+ $apiUrl = $dispatcher->url($request, PKPApplication::ROUTE_API, $context->getPath(), 'contexts/' . $context->getId());
  $lockssUrl = $router->url($request, $context->getPath(), 'gateway', 'lockss');
  $clockssUrl = $router->url($request, $context->getPath(), 'gateway', 'clockss');
 
@@ -91,9 +91,9 @@ function distribution($args, $request) {
 
  if ($plnPlugin) {
  $plnPlugin = PluginRegistry::getPlugin('generic', 'plnplugin');
- $pnEnablePluginUrl = $dispatcher->url($request, ROUTE_COMPONENT, null, 'grid.settings.plugins.SettingsPluginGridHandler', 'enable', null, array('plugin' => 'plnplugin', 'category' => 'generic'));
- $pnDisablePluginUrl = $dispatcher->url($request, ROUTE_COMPONENT, null, 'grid.settings.plugins.SettingsPluginGridHandler', 'disable', null, array('plugin' => 'plnplugin', 'category' => 'generic'));
- $pnSettingsUrl = $dispatcher->url($request, ROUTE_COMPONENT, null, 'grid.settings.plugins.SettingsPluginGridHandler', 'manage', null, array('verb' => 'settings', 'plugin' => 'plnplugin', 'category' => 'generic'));
+ $pnEnablePluginUrl = $dispatcher->url($request, PKPApplication::ROUTE_COMPONENT, null, 'grid.settings.plugins.SettingsPluginGridHandler', 'enable', null, array('plugin' => 'plnplugin', 'category' => 'generic'));
+ $pnDisablePluginUrl = $dispatcher->url($request, PKPApplication::ROUTE_COMPONENT, null, 'grid.settings.plugins.SettingsPluginGridHandler', 'disable', null, array('plugin' => 'plnplugin', 'category' => 'generic'));
+ $pnSettingsUrl = $dispatcher->url($request, PKPApplication::ROUTE_COMPONENT, null, 'grid.settings.plugins.SettingsPluginGridHandler', 'manage', null, array('verb' => 'settings', 'plugin' => 'plnplugin', 'category' => 'generic'));
 
  $archivePnForm->addField(new \APP\components\forms\FieldArchivingPn('pn', [
  'label' => __('manager.setup.plnPluginArchiving'),

diff --git a/pages/payments/PaymentsHandler.inc.php b/pages/payments/PaymentsHandler.inc.php
@@ -68,15 +68,15 @@ function subscriptions($args, $request) {
  return $templateMgr->fetchAjax(
  'institutionalSubscriptionsGridContainer',
  $dispatcher->url(
- $request, ROUTE_COMPONENT, null,
+ $request, PKPApplication::ROUTE_COMPONENT, null,
  'grid.subscriptions.InstitutionalSubscriptionsGridHandler', 'fetchGrid'
  )
  );
  case 'individual':
  return $templateMgr->fetchAjax(
  'individualSubscriptionsGridContainer',
  $dispatcher->url(
- $request, ROUTE_COMPONENT, null,
+ $request, PKPApplication::ROUTE_COMPONENT, null,
  'grid.subscriptions.IndividualSubscriptionsGridHandler', 'fetchGrid'
  )
  );
@@ -95,7 +95,7 @@ function subscriptionTypes($args, $request) {
  return $templateMgr->fetchAjax(
  'subscriptionTypesGridContainer',
  $dispatcher->url(
- $request, ROUTE_COMPONENT, null,
+ $request, PKPApplication::ROUTE_COMPONENT, null,
  'grid.subscriptions.SubscriptionTypesGridHandler', 'fetchGrid'
  )
  );
@@ -197,7 +197,7 @@ function payments($args, $request) {
  return $templateMgr->fetchAjax(
  'paymentsGridContainer',
  $dispatcher->url(
- $request, ROUTE_COMPONENT, null,
+ $request, PKPApplication::ROUTE_COMPONENT, null,
  'grid.subscriptions.PaymentsGridHandler', 'fetchGrid'
  )
  );

diff --git a/pages/workflow/WorkflowHandler.inc.php b/pages/workflow/WorkflowHandler.inc.php
@@ -62,9 +62,9 @@ function setupIndex($request) {
 
  $latestPublication = $submission->getLatestPublication();
 
- $latestPublicationApiUrl = $request->getDispatcher()->url($request, ROUTE_API, $submissionContext->getPath(), 'submissions/' . $submission->getId() . '/publications/' . $latestPublication->getId());
- $temporaryFileApiUrl = $request->getDispatcher()->url($request, ROUTE_API, $submissionContext->getPath(), 'temporaryFiles');
- $issueApiUrl = $request->getDispatcher()->url($request, ROUTE_API, $submissionContext->getData('urlPath'), 'issues/__issueId__');
+ $latestPublicationApiUrl = $request->getDispatcher()->url($request, PKPApplication::ROUTE_API, $submissionContext->getPath(), 'submissions/' . $submission->getId() . '/publications/' . $latestPublication->getId());
+ $temporaryFileApiUrl = $request->getDispatcher()->url($request, PKPApplication::ROUTE_API, $submissionContext->getPath(), 'temporaryFiles');
+ $issueApiUrl = $request->getDispatcher()->url($request, PKPApplication::ROUTE_API, $submissionContext->getData('urlPath'), 'issues/__issueId__');
 
  import('classes.file.PublicFileManager');
  $publicFileManager = new PublicFileManager();
@@ -97,7 +97,7 @@ function setupIndex($request) {
  ]);
  if ($paymentManager->publicationEnabled()) {
  $submissionPaymentsForm = new APP\components\forms\publication\SubmissionPaymentsForm(
- $request->getDispatcher()->url($request, ROUTE_API, $submissionContext->getPath(), '_submissions/' . $submission->getId() . '/payment'),
+ $request->getDispatcher()->url($request, PKPApplication::ROUTE_API, $submissionContext->getPath(), '_submissions/' . $submission->getId() . '/payment'),
  $submission,
  $request->getContext()
  );
@@ -119,7 +119,7 @@ function setupIndex($request) {
 
  $assignToIssueUrl = $request->getDispatcher()->url(
  $request,
- ROUTE_COMPONENT,
+ PKPApplication::ROUTE_COMPONENT,
  null,
  'modals.publish.AssignToIssueHandler',
  'assign',
@@ -172,7 +172,7 @@ protected function getEditorAssignmentNotificationTypeByStageId($stageId) {
  protected function _getRepresentationsGridUrl($request, $submission) {
  return $request->getDispatcher()->url(
  $request,
- ROUTE_COMPONENT,
+ PKPApplication::ROUTE_COMPONENT,
  null,
  'grid.articleGalleys.ArticleGalleyGridHandler',
  'fetchGrid',

diff --git a/plugins/blocks/information/templates/block.tpl b/plugins/blocks/information/templates/block.tpl
@@ -15,21 +15,21 @@
  <ul>
  {if !empty($forReaders)}
  <li>
- <a href="{url router=$smarty.const.ROUTE_PAGE page="information" op="readers"}">
+ <a href="{url router=PKPApplication::ROUTE_PAGE page="information" op="readers"}">
  {translate key="navigation.infoForReaders"}
  </a>
  </li>
  {/if}
  {if !empty($forAuthors)}
  <li>
- <a href="{url router=$smarty.const.ROUTE_PAGE page="information" op="authors"}">
+ <a href="{url router=PKPApplication::ROUTE_PAGE page="information" op="authors"}">
  {translate key="navigation.infoForAuthors"}
  </a>
  </li>
  {/if}
  {if !empty($forLibrarians)}
  <li>
- <a href="{url router=$smarty.const.ROUTE_PAGE page="information" op="librarians"}">
+ <a href="{url router=PKPApplication::ROUTE_PAGE page="information" op="librarians"}">
  {translate key="navigation.infoForLibrarians"}
  </a>
  </li>

diff --git a/plugins/blocks/languageToggle/templates/block.tpl b/plugins/blocks/languageToggle/templates/block.tpl
@@ -17,7 +17,7 @@
  <ul>
  {foreach from=$languageToggleLocales item=localeName key=localeKey}
  <li class="locale_{$localeKey|escape}{if $localeKey == $currentLocale} current{/if}" lang="{$localeKey|replace:"_":"-"}">
- <a href="{url router=$smarty.const.ROUTE_PAGE page="user" op="setLocale" path=$localeKey source=$smarty.server.REQUEST_URI}">
+ <a href="{url router=PKPApplication::ROUTE_PAGE page="user" op="setLocale" path=$localeKey source=$smarty.server.REQUEST_URI}">
  {$localeName}
  </a>
  </li>