Fix guest users being able to create dashboards

Former-commit-id: 3a4ddcc
Egokitek · May 29, 2020 · 2a891cb · 2a891cb
1 parent 1c5c8bb
commit 2a891cb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,7 @@ WARNING: There are changes with this version that may cause issues with your cur
  - Fix hostname display on login page
  - Fix missing blank line check for LCDs with 8 lines ([#771](https://github.com/kizniche/mycodo/issues/771))
  - Fix unset user groups when executing shell commands
+ - Fix guest users being able to create dashboards
 
 ### Features
 

diff --git a/mycodo/mycodo_flask/routes_page.py b/mycodo/mycodo_flask/routes_page.py
@@ -542,7 +542,9 @@ def page_dashboard_default():
 @blueprint.route('/dashboard-add', methods=('GET', 'POST'))
 @flask_login.login_required
 def page_dashboard_add():
-    """Load default dashboard"""
+    """Add a dashboard"""
+    if not utils_general.user_has_permission('edit_controllers'):
+        return redirect(url_for('routes_general.home'))
     dashboard_id = utils_dashboard.dashboard_add()
     return redirect(url_for(
         'routes_page.page_dashboard', dashboard_id=dashboard_id))