Skip to content

Commit

Permalink
workaround tornado py38 compatibility issue
Browse files Browse the repository at this point in the history
by setting the pre-3.8 eventloop policy as default
  • Loading branch information
minrk committed Nov 12, 2019
1 parent 9640e1f commit 29ec936
Showing 1 changed file with 34 additions and 0 deletions.
34 changes: 34 additions & 0 deletions notebook/notebookapp.py
Original file line number Diff line number Diff line change
Expand Up @@ -1707,8 +1707,42 @@ def init_shutdown_no_activity(self):
pc = ioloop.PeriodicCallback(self.shutdown_no_activity, 60000)
pc.start()

def _init_asyncio_patch(self):
"""set default asyncio policy to be compatible with tornado
Tornado 6 (at least) is not compatible with the default
asyncio implementation on Windows
Pick the older SelectorEventLoopPolicy on Windows
if the known-incompatible default policy is in use.
do this as early as possible to make it a low priority and overrideable
ref: https://github.com/tornadoweb/tornado/issues/2608
FIXME: if/when tornado supports the defaults in asyncio,
remove and bump tornado requirement for py38
"""
if sys.platform.startswith("win") and sys.version_info >= (3, 8):
import asyncio
try:
from asyncio import (
WindowsProactorEventLoopPolicy,
WindowsSelectorEventLoopPolicy,
)
except ImportError:
pass
# not affected
else:
if type(asyncio.get_event_loop_policy()) is WindowsProactorEventLoopPolicy:
# WindowsProactorEventLoopPolicy is not compatible with tornado 6
# fallback to the pre-3.8 default of Selector
asyncio.set_event_loop_policy(WindowsSelectorEventLoopPolicy())

@catch_config_error
def initialize(self, argv=None):
self._init_asyncio_patch()

super(NotebookApp, self).initialize(argv)
self.init_logging()
if self._dispatching:
Expand Down

0 comments on commit 29ec936

Please sign in to comment.