[[CHORE]] Refactor to support esversion: 2017

This change simply enables the configuration settings `esversion: 8` and `esversion: 2017` without introducing any new parsing/linting functionality.
EnotionZ · Jan 14, 2019 · dc29e78 · dc29e78
1 parent 4a5a4a5
commit dc29e78
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 2 deletions.
diff --git a/src/jshint.js b/src/jshint.js
@@ -674,11 +674,13 @@ var JSHINT = (function() {
           case "5":
           case "6":
           case "7":
+          case "8":
             state.option.moz = false;
             state.option.esversion = +val;
             break;
           case "2015":
           case "2016":
+          case "2017":
             state.option.moz = false;
             // Translate specification publication year to version number.
             state.option.esversion = +val - 2009;

diff --git a/tests/test262/test.js b/tests/test262/test.js
@@ -49,7 +49,7 @@ module.exports = function(test) {
   var isModule = !!test.attrs.flags.module;
 
   try {
-    JSHint(test.contents, { esversion: 7, maxerr: Infinity, module: isModule });
+    JSHint(test.contents, { esversion: 8, maxerr: Infinity, module: isModule });
   } catch (e) {
     return false;
   }

diff --git a/tests/unit/options.js b/tests/unit/options.js
@@ -4036,7 +4036,9 @@ exports.esversion = function(test) {
     "// jshint esversion: 6",
     "// jshint esversion: 2015",
     "// jshint esversion: 7",
-    "// jshint esversion: 2016"
+    "// jshint esversion: 2016",
+    "// jshint esversion: 8",
+    "// jshint esversion: 2017"
   ];
 
   TestRun(test, "Value")
@@ -4086,6 +4088,9 @@ exports.esversion = function(test) {
   TestRun(test, "ES6 syntax as ES7")
     .test(es6code, { esversion: 7 });
 
+  TestRun(test, "ES6 syntax as ES8")
+    .test(es6code, { esversion: 8 });
+
 
   // Array comprehensions aren't defined in ECMAScript 6,
   // but they can be enabled using the `esnext` option
@@ -4104,6 +4109,11 @@ exports.esversion = function(test) {
                  "(use moz option).")
     .test(arrayComprehension, { esversion: 7 });
 
+  TestRun(test, "array comprehensions - esversion: 8")
+    .addError(2, 9, "'array comprehension' is only available in Mozilla JavaScript extensions " +
+                 "(use moz option).")
+    .test(arrayComprehension, { esversion: 8 });
+
   TestRun(test, "array comprehensions - esnext: true")
     .test(arrayComprehension, { esnext: true });
 

diff --git a/tests/unit/parser.js b/tests/unit/parser.js
@@ -5888,6 +5888,7 @@ exports["fat arrows support"] = function (test) {
 
   run.test(code, { undef: true, esnext: true });
   run.test(code, { undef: true, esversion: 2016 });
+  run.test(code, { undef: true, esversion: 2017 });
 
   run = TestRun(test)
     .addError(1, 14, "'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').")
@@ -8524,6 +8525,7 @@ exports["new.target"] = function (test) {
 
   TestRun(test, "only in ES6").test(code, { esnext: true });
   TestRun(test, "ES7").test(code, { esversion: 7 });
+  TestRun(test, "ES8").test(code, { esversion: 8 });
 
   var code2 = [
     "var a = new.target;",
@@ -8561,6 +8563,12 @@ exports["new.target"] = function (test) {
     .addError(6, 13, "'new.target' must be in function scope.")
     .test(code2, { esversion: 2016 });
 
+  TestRun(test, "must be in function scope")
+    .addError(1, 12, "'new.target' must be in function scope.")
+    .addError(4, 15, "'new.target' must be in function scope.")
+    .addError(6, 13, "'new.target' must be in function scope.")
+    .test(code2, { esversion: 2017 });
+
   var code3 = [
     "var x = new.meta;"
   ];