Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Run lit tests on linux #435

Merged
merged 1 commit into from
Mar 5, 2025
Merged

CI: Run lit tests on linux #435

merged 1 commit into from
Mar 5, 2025

Conversation

Pangoraw
Copy link
Collaborator

@Pangoraw Pangoraw commented Mar 5, 2025

testing this one

testing this one
@giordano
Copy link
Member

giordano commented Mar 5, 2025

They're bound to fail: #369 (comment)

@Pangoraw
Copy link
Collaborator Author

Pangoraw commented Mar 5, 2025

I am filtering to run only the lit tests //lit_tests/*

@giordano
Copy link
Member

giordano commented Mar 5, 2025

Tangentially related, I'm testing using Python 3.11 to solve some issues (installing tensorflow with python 3.12 fails because of distutils being removed). That should solve a bunch of issues, but on hydra I still have segfaults in some tests (as I had mentioned in #426 (comment) already)

@giordano
Copy link
Member

giordano commented Mar 5, 2025

I am filtering to run only the lit tests //lit_tests/*

Ah, testing only those may work, yes.

@Pangoraw
Copy link
Collaborator Author

Pangoraw commented Mar 5, 2025

image

It's better than nothing and in the context of GB, python tests are not as important IMHO.

@Pangoraw Pangoraw marked this pull request as ready for review March 5, 2025 12:45
@wsmoses wsmoses merged commit 34fada0 into main Mar 5, 2025
8 checks passed
@giordano
Copy link
Member

giordano commented Mar 5, 2025

Tangentially related, I'm testing using Python 3.11 to solve some issues

For the record, can confirm that with Python 3.11 packaging issues are solved, but two tests still fail:

If we can exclude these 2-3 tests we can run all the rest (no idea how it's easy to do filter out few tests with Bazel)

@Pangoraw
Copy link
Collaborator Author

Pangoraw commented Mar 5, 2025

That's nice we can replace the filter with something like

bazel test ... $(bazel query //test/... 2>/dev/null | grep -v "keras_test" | grep -v "neuralgcm_test" | grep -v "llama")

@Pangoraw Pangoraw deleted the Pangoraw-patch-1 branch March 6, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants