Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme #156

Merged
merged 1 commit into from
Aug 5, 2024
Merged

update readme #156

merged 1 commit into from
Aug 5, 2024

Conversation

ZuseZ4
Copy link
Member

@ZuseZ4 ZuseZ4 commented Aug 5, 2024

No description provided.

@ZuseZ4 ZuseZ4 merged commit 0bd1b5d into master Aug 5, 2024
8 of 12 checks passed
@samestep
Copy link

Thanks for documenting this! Currently on my machine this fails with the following error message:

error: the `-Z unstable-options` flag must also be passed to enable the flag `check-cfg`
error: the `-Z unstable-options` flag must also be passed to enable the flag `check-cfg`


error: could not compile `samples` (lib test)
warning: build failed, waiting for other jobs to finish...
error: could not compile `samples` (lib)

@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Aug 12, 2024

Yes, but that error should go away and the examples should compile if you pass the flag. I am not sure if it will be still needed once I rebased and the error message in this case at least is correct, so I didn't add it to the docs.

@samestep
Copy link

@ZuseZ4 so I should clean my Enzyme build and try again with the latest main and it will work?

@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Aug 12, 2024

No, the rebase is still work in progress. And I am not 100% sure if it will directly be sufficient to remove this error, I'll decide afterwards if I can get rid of it, or if I need to add it to the docs. This is the WIP rebase PR: #162
For now I'd recommend to just set the flag, that will be less work. Also keep in mind that some of the docs changed recently, mainly https://enzyme.mit.edu/rust/Debugging.html#supported-rustflags

Edit: To be clear the latest flags as per docs are only supported if you pull and rebuild, but that alone won't remove the error you've seen above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants