Fix tag starting position #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why was this ever even a thing???
Removes offset and sets default angle to 0 degrees, directly right of the aircraft. This is a somewhat messy workaround to ensure the tag never starts out overlapping the radar return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since the left-right alignment days, the tag has started out slightly to the left and either above or on top of the radar return.
This was a bug.
It also left aligned despite the leader line being sliiiightly to the left of the radar return and vice versa on the bottom. This has annyed me forever.
No more.
This MR does the following:
Remaining at this point is the leader line length variable not actually defining the leader line length. Rather it defines the distance from the tag "start point" to the PRS. The start point is defined as top left when using LtR and top left when using RtL.
It may be intuitive now that when a tag has four lines, such as when there is an error, and is positioned above or to the left of the RPS, this makes a significant distance in the actual line length.