Skip to content

Commit

Permalink
Fix todoby for CDN (#2437)
Browse files Browse the repository at this point in the history
* fix `todoby`

* increase time to wait for builder

* echo when starting and stopping

* 2204

* 20 04?

* demo l1 started

* Revert "demo l1 started"

This reverts commit aede050.

* sleep

* latest

* fee contract not ready yet

* Revert "increase time to wait for builder"

This reverts commit 98dc7c7.

* Revert "echo when starting and stopping"

This reverts commit ddea3a2.

* Revert "20 04?"

This reverts commit 089c30d.

* Revert "sleep"

This reverts commit 81e6b89.

* Revert "latest"

This reverts commit 43d57ac.

* Revert "fee contract not ready yet"

This reverts commit b62f343.

* 2204

* print notready status every 5s

* kitchen sink

* decrease interval

* change readiness check

* docker ps

* grep

* supress error

* fix command

* double readiness period

* try failure threshold -> 6

* revert

* docker ps -> nc
  • Loading branch information
rob-maron authored Jan 7, 2025
1 parent f68a58e commit 8ed762c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
7 changes: 3 additions & 4 deletions process-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,9 @@ processes:
command: docker compose up demo-l1-network --force-recreate --renew-anon-volumes
readiness_probe:
exec:
command: "[ $(docker inspect -f '{{.State.Health.Status}}' espresso-sequencer-demo-l1-network-1) = 'healthy' ]"
period_seconds: 1
timeout_seconds: 5
failure_threshold: 30
command: nc -zv localhost $ESPRESSO_SEQUENCER_L1_PORT
failure_threshold: 6
initial_delay_seconds: 5

deploy-sequencer-contracts:
# The contract addresses are implicitly inherited from .env. We need to unset these or else the
Expand Down
4 changes: 2 additions & 2 deletions sequencer/src/network/cdn.rs
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ impl<T: SignatureKey> SignatureScheme for WrappedSignatureKey<T> {
};

todo_by!(
"2025-1-4",
"2025-2-4",
"Only accept the namespaced message once everyone has upgraded"
);
public_key.0.validate(&signature, message)
Expand Down Expand Up @@ -112,7 +112,7 @@ impl<TYPES: NodeType> RunDef for ProductionDef<TYPES> {
}

todo_by!(
"2025-1-4",
"2025-2-4",
"Remove this, switching to TCP+TLS singularly when everyone has updated"
);
/// The user definition for the Push CDN.
Expand Down

0 comments on commit 8ed762c

Please sign in to comment.