Fix memory leak

EttienneS · Nov 28, 2016 · bc87029 · bc87029
1 parent 2d71bb7
commit bc87029
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/VoronoiLib/FortunesAlgorithm.cs b/VoronoiLib/FortunesAlgorithm.cs
@@ -18,7 +18,6 @@ public static LinkedList<VEdge> Run(List<FortuneSite> sites, double minX, double
             var edges = new LinkedList<VEdge>();
             var deleted = new HashSet<FortuneCircleEvent>();
 
-            //TODO: Figure out memory leak with deleted...
             //init edge list
             while (eventQueue.Count != 0)
             {
@@ -33,6 +32,7 @@ public static LinkedList<VEdge> Run(List<FortuneSite> sites, double minX, double
                     }
                     else
                     {
+                        //previously processed is being added to deleted...
                         beachLine.RemoveBeachSection((FortuneCircleEvent) fEvent, eventQueue, deleted, edges);
                     }
                 }

diff --git a/VoronoiLib/Structures/BeachLine.cs b/VoronoiLib/Structures/BeachLine.cs
@@ -221,7 +221,7 @@ internal void RemoveBeachSection(FortuneCircleEvent circle, MinHeap<FortuneEvent
             var vertex = new VPoint(x, y);
 
             //multiple edges could end here
-            var toBeRemoved = new List<RBTreeNode<BeachSection>> {section};
+            var toBeRemoved = new List<RBTreeNode<BeachSection>>();
 
             //look left
             var prev = section.Previous;
@@ -242,6 +242,10 @@ internal void RemoveBeachSection(FortuneCircleEvent circle, MinHeap<FortuneEvent
                 next = next.Next;
             }
 
+            section.Data.Edge.End = vertex;
+            section.Next.Data.Edge.End = vertex;
+            section.Data.CircleEvent = null;
+
             //odds are this double writes a few edges but this is clean...
             foreach (var remove in toBeRemoved)
             {