build: convert setup.py to pyproject.toml #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanise
force-pushed
the
dev.ej/pyproject
branch
from
875210b to
6310e6f
Compare
This was referenced Feb 4, 2025
SamuelLarkin
approved these changes
Feb 7, 2025
| description = "Text/Speech Alignment Speech Generation for Indigenous Language Education Small Teams Project" | ||
| readme = "README.md" | ||
| license = "MIT" | ||
| requires-python = ">=3.10" |
There was a problem hiding this comment.
Suggested change
| requires-python = ">=3.10" | |
| requires-python = ">=3.10, <3.12" |
Co-authored-by: Samuel Larkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Goal?
Modernize the installation procedure for this module too.
Fixes?
The fact that pip 25 won't support setup.py anymore.
Feedback sought?
Make sure it's all OK and all the values I declared in each field are accurate.
Priority?
low
Tests added?
n/a
How to test?
pip install -e .andpip install -e .[dev]in DeepForcedAligner.python -m build --sdist --wheelbefore and after produce the correct wheel and tar ball.Confidence?
medium-high
Version change?
Yes, because if you're installed before, you will have gotten version
0.0.<date>, so now I'm making it0.1.0so the newer install has a higher version number.Related PRs?
EveryVoiceTTS/wav2vec2aligner#18
EveryVoiceTTS/FastSpeech2_lightning#108
EveryVoiceTTS/HiFiGAN_iSTFT_lightning#48
EveryVoiceTTS/EveryVoice#632