Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong default number id usages #55535

Merged
merged 15 commits into from
Jan 30, 2025
+278 −151
Merged

Fix wrong default number id usages #55535

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
66bd902
Remove wrong default number id usage pt1
VickyStash Jan 21, 2025
e06ad3f
Remove wrong default number id usage pt2
VickyStash Jan 21, 2025
9452d40
Fix lint errors
VickyStash Jan 21, 2025
8f0985f
Merge branch 'refs/heads/main' into VickyStash/refactor/50360-wrong-d…
VickyStash Jan 27, 2025
2e0c7aa
Remove wrong default number id usage pt3
VickyStash Jan 27, 2025
7683dfe
Remove wrong default number id usage pt4
VickyStash Jan 27, 2025
f2e7385
Remove wrong default number id usage pt5
VickyStash Jan 27, 2025
0e1727e
Lint fixes
VickyStash Jan 27, 2025
3d06687
Minor improvement
VickyStash Jan 27, 2025
b014cfb
Fix group chat creation
VickyStash Jan 27, 2025
7f108a2
Merge branch 'refs/heads/main' into VickyStash/refactor/50360-wrong-d…
VickyStash Jan 28, 2025
7d50b32
Remove wrong default ids in SplitBillDetailsPage
VickyStash Jan 28, 2025
17eee00
Minor code improvement
VickyStash Jan 28, 2025
5a9964a
Bump eslint-config-expensify version to 2.0.76
VickyStash Jan 29, 2025
fa465a4
Merge branch 'refs/heads/main' into VickyStash/refactor/50360-wrong-d…
VickyStash Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor code improvement
  • Loading branch information
@VickyStash
VickyStash committed Jan 28, 2025
commit 17eee00911001910291df5e517610fe3c6579f85
2 changes: 1 addition & 1 deletion src/pages/NewChatPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ function NewChatPage() {
(option: ListItem & Partial<OptionData>) => {
const isOptionInList = !!option.isSelected;

let newSelectedOptions = [...selectedOptions];
let newSelectedOptions;

if (isOptionInList) {
newSelectedOptions = reject(selectedOptions, (selectedOption) => selectedOption.login === option.login);
Expand Down
Loading