-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create configure-per-diem #56776
base: main
Are you sure you want to change the base?
Create configure-per-diem #56776
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @alexpensify |
@Beamanator @alexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Hmm for these, are you reviewing first @alexpensify ? I don't deal with these often 😅 |
Yeah @alexpensify can review this one |
Sorry, @bfitzexpensify, I worked limited hours last week and have been offline since Thursday evening. I'm still catching up, so I'll complete the review tomorrow. |
@bfitzexpensify - I reviewed the article via the PR but it looks like this GH is missing the helpdot.pages.dev link. Any ideas as to why the preview link is missing? Everything else looks good! |
@Beamanator after @bfitzexpensify shares feedback - these updates to the help site are ready to be merged! Thanks! |
We're good to merge here @Beamanator |
Hmm is this something we normally update @bfitzexpensify ? |
Explanation of Change
Fixed Issues
Related to https://github.com/Expensify/Expensify/issues/400276#issuecomment-2499292625
Do NOT add the special GH keywords like
fixed
etc, we have our own process of managing the flow.It MUST be an entire link to the github issue and your comment proposal ; otherwise, the linking and its automation will not work as expected.
Make sure this section looks similar to this (you can link multiple issues using the same formatting, just add a new line):
$ https://github.com/Expensify/App/issues/
$ https://github.com/Expensify/App/issues/<issueID(comment)>
Do NOT only link the issue number like this: $ #
--->
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop