Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Handling potential errors gracefully #18476

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

y-bharath14
Copy link
Contributor

Handling potential errors gracefully at exa-receive.py

@frrbot frrbot bot added the tests Topotests, make check, etc label Mar 24, 2025
# Create a new log directory
os.makedirs(logdir)
except OSError as e:
print("Error in creating log directory: {}".format(e))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use f-string instead.

try:
routesavefile = open(savepath, "w")
except IOError as e:
print("Error in opening log file: {}".format(e))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use f-string instead.

@ton31337
Copy link
Member

Squash commits, no fixup commits, please.

Handling potential errors gracefully at exa-receive.py

Signed-off-by: y-bharath14 <[email protected]>
@y-bharath14
Copy link
Contributor Author

Squash commits, no fixup commits, please.

Hello Donatas Abraitis,

Done!

Thanks & Regards,
Bharath

@y-bharath14 y-bharath14 requested a review from ton31337 March 25, 2025 01:06
@ton31337 ton31337 merged commit d19854c into FRRouting:master Mar 26, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master size/S tests Topotests, make check, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants