Skip to content

Commit

Permalink
AWS OIDC - List RDS: add VPC ID (gravitational#30971)
Browse files Browse the repository at this point in the history
* AWS OIDC - List RDS: add VPC ID

When deploying a Teleport service using the AWS OIDC DeployService, we
can provide the SecurityGroups to be applied to the network
configuration of the service.

Using the default SG for the VPC (vpc is inferred from the used subnets)
might not always be the best one (it is usually locked down).

The VPC is required to list the possible SecurityGroups.

Currently, there's no VPC information in the database.

This PR adds a new field to the AWS.RDS fields to indicate which VPC is
this Database in.

When running the DeployService, the user should be able to list the
Security Groups and then pick one or many to apply to the service.

* vpcId to vpcID
  • Loading branch information
marcoandredinis authored Aug 31, 2023
1 parent 630db38 commit 3dbd0b8
Show file tree
Hide file tree
Showing 4 changed files with 1,499 additions and 1,446 deletions.
2 changes: 2 additions & 0 deletions api/proto/teleport/legacy/types/types.proto
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,8 @@ message RDS {
bool IAMAuth = 4 [(gogoproto.jsontag) = "iam_auth"];
// Subnets is a list of subnets for the RDS instance.
repeated string Subnets = 5 [(gogoproto.jsontag) = "subnets,omitempty"];
// VPCID is the VPC where the RDS is running.
string VPCID = 6 [(gogoproto.jsontag) = "vpc_id,omitempty"];
}

// RDSProxy contains AWS RDS Proxy specific database metadata.
Expand Down
Loading

0 comments on commit 3dbd0b8

Please sign in to comment.