Fix update strategy calculation for DaemonSet

Fei-Guo · Aug 26, 2020 · dacfbcd · dacfbcd
1 parent 447f902
commit dacfbcd
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pkg/controller/daemonset/update.go b/pkg/controller/daemonset/update.go
@@ -523,7 +523,9 @@ func (dsc *ReconcileDaemonSet) filterDaemonPodsNodeToUpdate(ds *appsv1alpha1.Dae
  } else {
  sorted = append(updated, rest...)
  }
- if maxUpdate := len(allNames) - int(partition); maxUpdate < len(sorted) {
+ if maxUpdate := len(allNames) - int(partition); maxUpdate <= 0 {
+ return nil, nil
+ } else if maxUpdate < len(sorted) {
  sorted = sorted[:maxUpdate]
  }
  return sorted, nil