Skip to content

Commit

Permalink
Fixing NullPointerException
Browse files Browse the repository at this point in the history
Summary: The previous diff missed the other usage

Reviewed By: czxttkl

Differential Revision: D15451561

fbshipit-source-id: d69c233d1a8e75a10dc06165e845d2463ca9bde6
  • Loading branch information
kittipatv authored and facebook-github-bot committed May 22, 2019
1 parent 7d2669a commit dd88c94
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,15 @@ object Helper {
def getDataTypes(sqlContext: SQLContext,
tableName: String,
columnNames: List[String]): Map[String, String] = {
// null check is required because jackson doesn't care about default values
val notNullColumnNames = Option(columnNames).getOrElse(List[String]())
val dt = sqlContext.sparkSession.catalog
.listColumns(tableName)
.collect
// null check is required because jackson doesn't care about default values
.filter(column => columnNames != null && columnNames.contains(column.name))
.filter(column => notNullColumnNames.contains(column.name))
.map(column => column.name -> column.dataType)
.toMap
assert(dt.size == columnNames.size)
assert(dt.size == notNullColumnNames.size)
dt
}

Expand Down

0 comments on commit dd88c94

Please sign in to comment.