fix(plugins): deck plugin versions should not be compared to the down…

…loading service's version (spinnaker#866) (spinnaker#918)

Co-authored-by: Daniel Peach <[email protected]>

fix(retrofit): handle HttpStatus.NOT_FOUND with a SpinnakerHttpExcept…

…ion instead of a NotFoundException (spinnaker#911)

since SpinnakerHttpException includes details from the http response in their exception
message.  Since these exceptions eventually make it to spinnaker pipeline execution json
and the spinnaker UI, these details can be important.  That's why this commit is
considered a fix -- it makes incomplete information more complete.

It’s simple and clear for code to be able to check for a NotFoundException when it needs
to. However, the current constructor for NotFoundException doesn’t include the message
from the http response and so that information is lost. It would be possible to build a
new constructor for NotFoundException that takes a RetrofitError and re-use the
functionality in SpinnakerServerException to parse the http response, but that doesn’t
help one of the other things that code calling other microservices sometimes needs to do —
catch exceptions, add to the message, and re-throw them. For that, when NotFoundException
is a special case, it’s more work than catching only, say, SpinnakerHttpException, so we
land on this approach.

Note that this is potentially a breaking change, as code that's catching NotFoundException
needs to change to catch SpinnakerHttpException and examine the status code.

fix(retrofit): handle non-message properties when deserializing respo…

…nse body in SpinnakerServerException (spinnaker#913)

Co-authored-by: calvintse <[email protected]>

fix(security): set platform restriction on log4j (spinnaker#912)

Bumps log4j platform restriction.  Though the core lib is NOT included in dependencies, better safe than sorry...

feat(build): publish to maven central, switch groupId to io.spinnaker… (

spinnaker#917)

Co-authored-by: Daniel Peach <[email protected]>
Co-authored-by: Cameron Motevasselani <[email protected]>

Handler for spinnaker server exception and spinnaker http exception (s…

…pinnaker#910)

* refactor(web/exceptions): create BaseExceptionHandlers class

to pave the way for an additional exception hander in kork-retrofit

* feat(retrofit): add SpinnakerRetrofitExceptionHandlers and handle SpinnakerServerException and SpinnakerHttpException

SpinnakerRetrofitErrorHandler (introduced in spinnaker#821)
converts RetrofitErrors into SpinnakerServerException errors (or one of its subclasses),
but there was no corresponding exception handler for SpinnakerServerException.  So, the
generic handleException method from kork-web's GenericExceptionHandlers handled
SpinnakerServerException and logged a warning with a whole stack trace in addition to the
error.

So, this commit adds a handler for SpinnakerServerException and SpinnakerHttpException to
restore the pre-SpinnakerRetrofitErrorHandler behavior where GenericExceptionHandlers's
handler for RetrofitErrors extracted relevant information.  SpinnakerServerException is
now responsible for retrieving information from the underlying RetrofitError and storing
it in the exception's message.

It also adds a RetrofitErrorConfiguration class in the com.netflix.spinnaker.config
package, following the same convention as ErrorConfiguration in kork-web, so code that
includes kork-retrofit and scans that package gets a SpinnakerRetrofitExceptionHandlers
bean.

* feat(retrofit): make SpinnakerHttpException, SpinnakerServerException chainable

fix(plugins): update constructors for jackson mappers (spinnaker#908)

When we moved to Jackson 2.12 there were some constructors that weren't
updated and weren't caught until runtime. I don't know enough about
Jackson's Kotlin integration to why this wasn't an issue. I built and
ran tests on master for this project and everything was fine, even after
making the constructor changes.

I tested this change by using composite builds to bring this into rosco
and see that it starts successfully now. I'm not sure if we'll need to
do similar kork bumps in other services.

Testcontainers 1.16.2 (spinnaker#907)

* test(kork-sql-test): add test for SqlTestUtil

* refactor(kork-sql-test): simplify jdbc url since somehost:someport are ignored

See https://www.testcontainers.org/modules/databases/jdbc/#database-containers-launched-via-jdbc-url-scheme

* chore(dependencies): use version 1.16.2 of testcontainers to stay up to date

Spectator 1.0.6 (spinnaker#906)

* chore(dependencies): clean up spectator dependencies

- change scope of spectator-web-spring dependencies from api to implementation since
  consumers of neither kork-stackdriver nor kork-web need it at compile time, and exclude
  transitives to keep spectator-web-spring's spring(boot) dependencies from overriding
  what we've defined elsewhere.  Add a test to ensure that the metrics endpoint from
  spectator-web-spring is really available.

- exclude transitive dependencies of spectator-ext-aws in kork-aws for a similar reason --
  to keep spectator-ext-aws' version of the aws sdk (and the aws sdk's transitives) from
  giving us newer versions of the sdk, jackson and kotlin than consumers are ready for.

This paves the way to upgrade to spectator 1.0.5 where a newer version of the spring(boot)
dependencies that spectator-web-spring brings in cause problems.

See Netflix/spectator#920 for background.

* chore(dependences): use version 1.0.6 of spectator to stay up to date

chore(dependencies): update the aws sdk to 1.12.100 (spinnaker#904)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>