Skip to content

Commit

Permalink
binman: btool: mkimage: use Bintool.version
Browse files Browse the repository at this point in the history
Bintool.version already contains everything required to get the version
out of mkimage binary so let's not override it with its own
implementation.

Signed-off-by: Quentin Schulz <[email protected]>
Reviewed-by: Simon Glass <[email protected]>
  • Loading branch information
QSchulz authored and sjg20 committed Sep 1, 2022
1 parent f17219a commit 65e2c14
Showing 1 changed file with 2 additions and 16 deletions.
18 changes: 2 additions & 16 deletions tools/binman/btool/mkimage.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ class Bintoolmkimage(bintool.Bintool):
Support is provided for fetching this on Debian-like systems, using apt.
"""
def __init__(self, name):
super().__init__(name, 'Generate image for U-Boot')
super().__init__(name, 'Generate image for U-Boot', r'mkimage version (.*)')

# pylint: disable=R0913
def run(self, reset_timestamp=False, output_fname=None, external=False,
pad=None, version=False):
pad=None):
"""Run mkimage
Args:
Expand All @@ -44,8 +44,6 @@ def run(self, reset_timestamp=False, output_fname=None, external=False,
args.append('-t')
if output_fname:
args += ['-F', output_fname]
if version:
args.append('-V')
return self.run_cmd(*args)

def fetch(self, method):
Expand All @@ -66,15 +64,3 @@ def fetch(self, method):
if method != bintool.FETCH_BIN:
return None
return self.apt_install('u-boot-tools')

def version(self):
"""Version handler for mkimage
Returns:
str: Version string for mkimage
"""
out = self.run(version=True).strip()
if not out:
return super().version()
m_version = re.match(r'mkimage version (.*)', out)
return m_version.group(1) if m_version else out

0 comments on commit 65e2c14

Please sign in to comment.