ps3vram: Use proc_create_data() instead of proc_create()

Use proc_create_data() to avoid race conditions. Reported-by: Alexey Dobriyan <[email protected]> Signed-off-by: Geert Uytterhoeven <[email protected]> Cc: Jim Paris <[email protected]> Cc: Jens Axboe <[email protected]> Signed-off-by: Benjamin Herrenschmidt <[email protected]>
Findingmyway · Jun 15, 2009 · 3c20e2f · 3c20e2f
1 parent 734957c
commit 3c20e2f
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/drivers/block/ps3vram.c b/drivers/block/ps3vram.c
@@ -546,12 +546,10 @@ static void __devinit ps3vram_proc_init(struct ps3_system_bus_device *dev)
 	struct ps3vram_priv *priv = dev->core.driver_data;
 	struct proc_dir_entry *pde;
 
-	pde = proc_create(DEVICE_NAME, 0444, NULL, &ps3vram_proc_fops);
-	if (!pde) {
+	pde = proc_create_data(DEVICE_NAME, 0444, NULL, &ps3vram_proc_fops,
+			       priv);
+	if (!pde)
 		dev_warn(&dev->core, "failed to create /proc entry\n");
-		return;
-	}
-	pde->data = priv;
 }
 
 static int ps3vram_make_request(struct request_queue *q, struct bio *bio)