Fix issue where passing 1 tab in would error out #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12164951316Details
💛 - Coveralls |
jakeobrien
approved these changes
Dec 4, 2024
lib/src/components/sheet.dart
Outdated
| length: widget.tabs.length, | ||
| vsync: this, | ||
| ); | ||
| if (widget.tabs.length > 1) { |
There was a problem hiding this comment.
low priority suggestion: might make sense to make a convenience function for this since it's used a few times. the function name could maybe go a little way to explain the reason for the requirement, like if it's a validation check for the control or if it only needs a tab controller if there's more than one tab.
There was a problem hiding this comment.
I agree I was just being lazy. I have updated to have a variable for this canShowTabs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9