Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing initialChildSize #8

Merged
merged 8 commits into from
Nov 18, 2024
Merged

fixing initialChildSize #8

merged 8 commits into from
Nov 18, 2024

Conversation

LegendAF
Copy link
Collaborator

@LegendAF LegendAF commented Nov 17, 2024 •
edited
Loading

Fix for #6

@LegendAF LegendAF changed the title WIP for fixing initialChildSize fixing initialChildSize Nov 17, 2024
@LegendAF LegendAF marked this pull request as ready for review November 17, 2024 10:13
@LegendAF LegendAF requested a review from a team as a code owner November 17, 2024 10:13
@LegendAF LegendAF mentioned this pull request Nov 17, 2024
Closed
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Nov 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11889544059

Details

  • 39 of 51 (76.47%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 60.677%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/components/search_field.dart 1 7 14.29%
lib/src/components/sheet.dart 36 42 85.71%
Files with Coverage Reduction New Missed Lines %
lib/src/components/tab_view.dart 1 29.23%
Totals Coverage Status
Change from base Build 11658571593: 0.4%
Covered Lines: 287
Relevant Lines: 473
💛 - Coveralls

josh-flyclops
josh-flyclops approved these changes Nov 18, 2024
View reviewed changes
Copy link

@josh-flyclops josh-flyclops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@LegendAF LegendAF merged commit 5235448 into main Nov 18, 2024
2 checks passed
@LegendAF LegendAF deleted the issues/6 branch November 18, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-flyclops josh-flyclops josh-flyclops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LegendAF @josh-flyclops