Skip to content

Commit

Permalink
Firefox WebExtension support (vuejs#341)
Browse files Browse the repository at this point in the history
* Add meta charset utf-8 to popups and bg page

* Refer to DevTools generically in enabled popup

* Add Firefox 48 as a buble target in webpack config

* Add Firefox to the manifest description
  • Loading branch information
clarkbw authored and yyx990803 committed Jun 15, 2017
1 parent a0dda6f commit 3dfdae5
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 4 deletions.
1 change: 1 addition & 0 deletions shells/chrome/devtools-background.html
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
<meta charset="utf-8">
<script src="./build/devtools-background.js"></script>
2 changes: 1 addition & 1 deletion shells/chrome/manifest.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "Vue.js devtools",
"version": "3.1.3",
"description": "Chrome devtools extension for debugging Vue.js applications.",
"description": "Chrome and Firefox DevTools extension for debugging Vue.js applications.",
"manifest_version": 2,
"icons": {
"16": "icons/16.png",
Expand Down
1 change: 1 addition & 0 deletions shells/chrome/popups/disabled.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<meta charset="utf-8">
<p style="width: 200px">
Vue.js is detected on this page.
Devtools inspection is not available because it's in
Expand Down
3 changes: 2 additions & 1 deletion shells/chrome/popups/enabled.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<meta charset="utf-8">
<p style="width: 180px;">
Vue.js is detected on this page.
Open Chrome Devtools and look for the Vue panel.
Open DevTools and look for the Vue panel.
</p>
1 change: 1 addition & 0 deletions shells/chrome/popups/not-found.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<meta charset="utf-8">
<p style="white-space: nowrap">
Vue.js not detected
</p>
2 changes: 1 addition & 1 deletion shells/chrome/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var webpack = require('webpack')
var alias = require('../alias')

var bubleOptions = {
target: process.env.NODE_ENV === 'production' ? null : { chrome: 52 },
target: process.env.NODE_ENV === 'production' ? null : { chrome: 52, firefox: 48 },
objectAssign: 'Object.assign'
}

Expand Down
2 changes: 1 addition & 1 deletion shells/dev/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ var alias = require('../alias')
var FriendlyErrorsPlugin = require('friendly-errors-webpack-plugin')

var bubleOptions = {
target: { chrome: 52 },
target: { chrome: 52, firefox: 48 },
objectAssign: 'Object.assign'
}

Expand Down

0 comments on commit 3dfdae5

Please sign in to comment.