chore: automate-docs #513
chore: automate-docs #513
Conversation
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4d0b4f5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
fix doc generation commands
ryanbas21
force-pushed
the
docs-generation
branch
from
5e0abc4 to
ea38c69
Compare
ryanbas21
force-pushed
the
docs-generation
branch
2 times, most recently
from
809a900 to
fc8fd76
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #513 +/- ##
==========================================
Coverage ? 57.24%
==========================================
Files ? 123
Lines ? 26966
Branches ? 1717
==========================================
Hits ? 15438
Misses ? 11528
Partials ? 0 ☔ View full report in Codecov by Sentry. |
ryanbas21
force-pushed
the
docs-generation
branch
3 times, most recently
from
1ccdc30 to
d99bb5c
Compare
add codecov, fix up tsconfigs, and add extenssions to mock-api-v2 for node16+ support
ryanbas21
force-pushed
the
docs-generation
branch
from
d99bb5c to
8456a8f
Compare
| @@ -92,3 +92,8 @@ jobs: | |||
| env: | |||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
| NPM_CONFIG_PROVENANCE: true | |||
|
|
|||
| - uses: codecov/codecov-action@v5 | |||
There was a problem hiding this comment.
after we publish everything, we can try to upload a coverage report. doing this after because by this point we should have
A) run tests, and builds
B) I don't want uploading coverage to affect the publish or versioning, etc
| @@ -69,9 +69,6 @@ | |||
| "{projectRoot}/{options.coverage.reportsDirectory}", | |||
| "{workspaceRoot}/coverage/e2e/mock-api-v2" | |||
| ], | |||
| "options": { | |||
There was a problem hiding this comment.
i've defined this all in the vite config.
| import { PingOneCustomHtmlResponseBody } from '../schemas/custom-html-template/custom-html-template-response.schema'; | ||
| import { SuccessResponseRedirect } from '../schemas/return-success-response-redirect.schema'; | ||
| } from '../schemas/authorize.schema.js'; | ||
| import { PingOneCustomHtmlResponseBody } from '../schemas/custom-html-template/custom-html-template-response.schema.js'; |
There was a problem hiding this comment.
updating tsconfigs made this a change, its all just adding extensions to files.
| coverage: { | ||
| reportsDirectory: '../../coverage/e2e/token-vault-interceptor', | ||
| reportsDirectory: './coverage', |
There was a problem hiding this comment.
keeping all directories local to the package it was from
| @@ -18,7 +18,9 @@ | |||
| } | |||
| }, | |||
| "docs": { | |||
There was a problem hiding this comment.
adding doc building to the pipeline.
This also runs tsc it seems. Basically if we "successfully build" docs in the CI we can choose to upload them somewhere in the future.
Also just gives us a check against all the types of tools we are useing, make sure it works in a fresh env.
fix doc generation commands
JIRA Ticket
Please link jira ticket here
Description
Type of Change
Please Delete options that are not relevant
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Definition of Done
Check all that apply
Documentation