-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix davinci package #520
Fix davinci package #520
Conversation
|
Name | Type |
---|---|
@forgerock/davinci-client | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3563b77. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
"main": "./dist/index.js", | ||
"module": "./dist/index.js", | ||
"typings": "./dist/index.d.ts", | ||
"type": "module", | ||
"files": ["dist"], | ||
"publishConfig": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an npm
requirement for publishing with provenance.
We either set it here, or add an ENV variable in the pipeline to allow this
NPM_CONFIG_ACCESS: public
f6eb8ef
to
3563b77
Compare
"main": "./dist/index.js", | ||
"module": "./dist/index.js", | ||
"typings": "./dist/index.d.ts", | ||
"type": "module", | ||
"files": ["dist"], | ||
"repository": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.npmjs.com/generating-provenance-statements#prerequisites
Ensure your package.json is configured with a public repository that matches (case-sensitive) where you are publishing with provenance from.
JIRA Ticket
Please link jira ticket here
Description
Type of Change
Please Delete options that are not relevant
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Definition of Done
Check all that apply
Documentation