Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add mrdrogdrog as a contributor for design #327

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

allcontributors[bot]
Copy link
Contributor

Add @mrdrogdrog as a contributor for design.

This was requested by shinenelson in this comment

@allcontributors allcontributors bot mentioned this pull request Aug 27, 2021
@shinenelson shinenelson merged commit 15f344c into master Aug 27, 2021
@shinenelson shinenelson deleted the all-contributors/add-mrdrogdrog branch August 27, 2021 07:23
@mrdrogdrog
Copy link
Contributor

Well. Actually the design is not made by me. I only created the pull request. Can we change this to the HedgeDoc project?

@shinenelson
Copy link
Member

ouch. Well, I'm not sure if all contributors can handle it. Let's test and find out. I'm still experimenting with the bot myself.

would @all-contributors be kind enough to replace @mrdrogdrog with @hedgedoc?

@allcontributors
Copy link
Contributor Author

@shinenelson

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

@shinenelson
Copy link
Member

okay, well in that case, @all-contributors remove @mrdrogdrog for design and add @hedgedoc for design

@allcontributors
Copy link
Contributor Author

@shinenelson

I've put up a pull request to add @hedgedoc! 🎉

@shinenelson
Copy link
Member

interesting... can @all-contributors remove @mrdrogdrog for design?

maybe, its against its ethos of recognizing all contributions and not removing them.

PS : I do not mean any offense @mrdrogdrog, I am trying to understand the capabilities of this bot.

@allcontributors
Copy link
Contributor Author

@shinenelson

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

@shinenelson
Copy link
Member

as expected, it can only add, not remove; which is a good thing, in a way 😉

@mrdrogdrog
Copy link
Contributor

Well then just revert the commit I guess 🤷

@shinenelson
Copy link
Member

I believe that we should credit YOU for the pull request, even though you did not design the logo itself. Since I could not find another category for people opening pull requests, I think it is okay for you to be in design for now. Unless you can identify another category that you would like to be credited in ( idea:bulb:, perhaps? ). Or if you strongly feel that it should be the project that is credited.

I think the aim with the all-contributors project is to recognize individual contributors ( humans ) rather than projects, etc.

@mrdrogdrog
Copy link
Contributor

Well. Do as you like 😅

@shinenelson
Copy link
Member

Very well, I will keep it as is and close #328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants